After commit 13ceb48bc19c ("MIPS: Loongson2ef: Remove unnecessary
{as,cc}-option calls"), no need to use "ifdef need-compiler" for
Kbuild.platforms, because the cause of the build issue mentioned
in commit 0706f74f719e ("MIPS: fix *-pkg builds for loongson2ef
platform") has been disappeared, so just remove it.
Signed-off-by: Tiezhu Yang <[email protected]>
---
v2: fix the typo "casue" --> "cause" in the commit message,
sorry for that.
arch/mips/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index ace7f03..e036fc0 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -253,9 +253,7 @@ endif
#
# Board-dependent options and extra files
#
-ifdef need-compiler
include $(srctree)/arch/mips/Kbuild.platforms
-endif
ifdef CONFIG_PHYSICAL_START
load-y = $(CONFIG_PHYSICAL_START)
--
2.1.0
On Fri, Dec 10, 2021 at 12:05:05PM +0800, Tiezhu Yang wrote:
> After commit 13ceb48bc19c ("MIPS: Loongson2ef: Remove unnecessary
> {as,cc}-option calls"), no need to use "ifdef need-compiler" for
> Kbuild.platforms, because the cause of the build issue mentioned
> in commit 0706f74f719e ("MIPS: fix *-pkg builds for loongson2ef
> platform") has been disappeared, so just remove it.
>
> Signed-off-by: Tiezhu Yang <[email protected]>
Reviewed-by: Nathan Chancellor <[email protected]>
> ---
>
> v2: fix the typo "casue" --> "cause" in the commit message,
> sorry for that.
>
> arch/mips/Makefile | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index ace7f03..e036fc0 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -253,9 +253,7 @@ endif
> #
> # Board-dependent options and extra files
> #
> -ifdef need-compiler
> include $(srctree)/arch/mips/Kbuild.platforms
> -endif
>
> ifdef CONFIG_PHYSICAL_START
> load-y = $(CONFIG_PHYSICAL_START)
> --
> 2.1.0
>
On Sat, Dec 11, 2021 at 1:22 AM Nathan Chancellor <[email protected]> wrote:
>
> On Fri, Dec 10, 2021 at 12:05:05PM +0800, Tiezhu Yang wrote:
> > After commit 13ceb48bc19c ("MIPS: Loongson2ef: Remove unnecessary
> > {as,cc}-option calls"), no need to use "ifdef need-compiler" for
> > Kbuild.platforms, because the cause of the build issue mentioned
> > in commit 0706f74f719e ("MIPS: fix *-pkg builds for loongson2ef
> > platform") has been disappeared, so just remove it.
> >
> > Signed-off-by: Tiezhu Yang <[email protected]>
>
> Reviewed-by: Nathan Chancellor <[email protected]>
>
> > ---
> >
> > v2: fix the typo "casue" --> "cause" in the commit message,
> > sorry for that.
> >
> > arch/mips/Makefile | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> > index ace7f03..e036fc0 100644
> > --- a/arch/mips/Makefile
> > +++ b/arch/mips/Makefile
> > @@ -253,9 +253,7 @@ endif
> > #
> > # Board-dependent options and extra files
> > #
> > -ifdef need-compiler
> > include $(srctree)/arch/mips/Kbuild.platforms
> > -endif
> >
> > ifdef CONFIG_PHYSICAL_START
> > load-y = $(CONFIG_PHYSICAL_START)
> > --
> > 2.1.0
> >
Nathan's patch cleaned up arch/mips/loognson2ef/Platform,
but I still see similar code in arch/mips/sgi-ip22/Platform.
ifdef CONFIG_SGI_IP28
ifeq ($(call cc-option-yn,-march=r10000 -mr10k-cache-barrier=store), n)
$(error gcc doesn't support needed option -mr10k-cache-barrier=store)
endif
endif
Doesn't this cause a failure of *-pkg builds for sgi-ip22 platform?
--
Best Regards
Masahiro Yamada
From: Masahiro Yamada <[email protected]>
Subject: Re: [PATCH v2] MIPS: Makefile: Remove "ifdef need-compiler" for Kbuild.platforms
Date: Sat, 11 Dec 2021 01:39:10 +0900
> Nathan's patch cleaned up arch/mips/loognson2ef/Platform,
> but I still see similar code in arch/mips/sgi-ip22/Platform.
>
>
> ifdef CONFIG_SGI_IP28
> ifeq ($(call cc-option-yn,-march=r10000 -mr10k-cache-barrier=store), n)
> $(error gcc doesn't support needed option -mr10k-cache-barrier=store)
> endif
> endif
>
>
> Doesn't this cause a failure of *-pkg builds for sgi-ip22 platform?
Yes, it does, as reported at
https://github.com/ClangBuiltLinux/linux/issues/1543
Best regards, Ryutaroh Matsumo
On Mon, Dec 13, 2021 at 09:35:20AM +0900, Ryutaroh Matsumoto wrote:
> From: Masahiro Yamada <[email protected]>
> Subject: Re: [PATCH v2] MIPS: Makefile: Remove "ifdef need-compiler" for Kbuild.platforms
> Date: Sat, 11 Dec 2021 01:39:10 +0900
> > Nathan's patch cleaned up arch/mips/loognson2ef/Platform,
> > but I still see similar code in arch/mips/sgi-ip22/Platform.
> >
> >
> > ifdef CONFIG_SGI_IP28
> > ifeq ($(call cc-option-yn,-march=r10000 -mr10k-cache-barrier=store), n)
> > $(error gcc doesn't support needed option -mr10k-cache-barrier=store)
> > endif
> > endif
> >
> >
> > Doesn't this cause a failure of *-pkg builds for sgi-ip22 platform?
>
> Yes, it does, as reported at
> https://github.com/ClangBuiltLinux/linux/issues/1543
It seems like that section can be removed for the same reason as my
patch (that flag is supported with GCC 5.1.0) then this patch can be
applied without any issues.
Cheers,
Nathan