LinuxLists.cc - [PATCH 0/3] x86: Syscall table cleanups

2021-05-24 18:18:58

Subject: [PATCH 0/3] x86: Syscall table cleanups

Here are a few patches following up to the syscall table generation
patches that are now in the -tip tree.

Brian Gerst (3):
x86/uml/syscalls: Remove array index from syscall initializers
x86/syscalls: Remove -Wno-override-init for syscall tables
x86/syscalls: Don't sdjust CFLAGS for syscall tables

arch/x86/entry/Makefile | 10 ----------
arch/x86/um/sys_call_table_32.c | 2 +-
arch/x86/um/sys_call_table_64.c | 2 +-
3 files changed, 2 insertions(+), 12 deletions(-)

--
2.31.1

2021-05-24 18:19:49

by Brian Gerst

[permalink] [raw]

Subject: [PATCH 2/3] x86/syscalls: Remove -Wno-override-init for syscall tables

Commit 44fe4895f47c ("Stop filling syscall arrays with *_sys_ni_syscall")
removes the need for -Wno-override-init, since the table is now filled
sequentially instead of overriding a default value.

Signed-off-by: Brian Gerst <[email protected]>
---
arch/x86/entry/Makefile | 4 ----
1 file changed, 4 deletions(-)

diff --git a/arch/x86/entry/Makefile b/arch/x86/entry/Makefile
index 08bf95dbc911..94d2843ce80c 100644
--- a/arch/x86/entry/Makefile
+++ b/arch/x86/entry/Makefile
@@ -17,10 +17,6 @@ CFLAGS_syscall_64.o += -fno-stack-protector
CFLAGS_syscall_32.o += -fno-stack-protector
CFLAGS_syscall_x32.o += -fno-stack-protector

-CFLAGS_syscall_64.o += $(call cc-option,-Wno-override-init,)
-CFLAGS_syscall_32.o += $(call cc-option,-Wno-override-init,)
-CFLAGS_syscall_x32.o += $(call cc-option,-Wno-override-init,)
-
obj-y := entry_$(BITS).o thunk_$(BITS).o syscall_$(BITS).o
obj-y += common.o

--
2.31.1

2021-05-24 18:20:34

by Brian Gerst

[permalink] [raw]

Subject: [PATCH 3/3] x86/syscalls: Don't sdjust CFLAGS for syscall tables

The syscall_*.c files only contain data (the syscall tables). There
is no need to adjust CFLAGS for tracing and stack protector since they
contain no code.

Signed-off-by: Brian Gerst <[email protected]>
---
arch/x86/entry/Makefile | 6 ------
1 file changed, 6 deletions(-)

diff --git a/arch/x86/entry/Makefile b/arch/x86/entry/Makefile
index 94d2843ce80c..7fec5dcf6438 100644
--- a/arch/x86/entry/Makefile
+++ b/arch/x86/entry/Makefile
@@ -8,14 +8,8 @@ UBSAN_SANITIZE := n
KCOV_INSTRUMENT := n

CFLAGS_REMOVE_common.o = $(CC_FLAGS_FTRACE)
-CFLAGS_REMOVE_syscall_64.o = $(CC_FLAGS_FTRACE)
-CFLAGS_REMOVE_syscall_32.o = $(CC_FLAGS_FTRACE)
-CFLAGS_REMOVE_syscall_x32.o = $(CC_FLAGS_FTRACE)

CFLAGS_common.o += -fno-stack-protector
-CFLAGS_syscall_64.o += -fno-stack-protector
-CFLAGS_syscall_32.o += -fno-stack-protector
-CFLAGS_syscall_x32.o += -fno-stack-protector

obj-y := entry_$(BITS).o thunk_$(BITS).o syscall_$(BITS).o
obj-y += common.o
--
2.31.1

2021-05-25 12:04:18

by Masahiro Yamada

[permalink] [raw]

Subject: Re: [PATCH 3/3] x86/syscalls: Don't sdjust CFLAGS for syscall tables

On Tue, May 25, 2021 at 3:17 AM Brian Gerst <[email protected]> wrote:
>
> The syscall_*.c files only contain data (the syscall tables). There
> is no need to adjust CFLAGS for tracing and stack protector since they
> contain no code.
>
> Signed-off-by: Brian Gerst <[email protected]>
> ---

Reviewed-by: Masahiro Yamada <[email protected]>

> arch/x86/entry/Makefile | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/x86/entry/Makefile b/arch/x86/entry/Makefile
> index 94d2843ce80c..7fec5dcf6438 100644
> --- a/arch/x86/entry/Makefile
> +++ b/arch/x86/entry/Makefile
> @@ -8,14 +8,8 @@ UBSAN_SANITIZE := n
> KCOV_INSTRUMENT := n
>
> CFLAGS_REMOVE_common.o = $(CC_FLAGS_FTRACE)
> -CFLAGS_REMOVE_syscall_64.o = $(CC_FLAGS_FTRACE)
> -CFLAGS_REMOVE_syscall_32.o = $(CC_FLAGS_FTRACE)
> -CFLAGS_REMOVE_syscall_x32.o = $(CC_FLAGS_FTRACE)
>
> CFLAGS_common.o += -fno-stack-protector
> -CFLAGS_syscall_64.o += -fno-stack-protector
> -CFLAGS_syscall_32.o += -fno-stack-protector
> -CFLAGS_syscall_x32.o += -fno-stack-protector
>
> obj-y := entry_$(BITS).o thunk_$(BITS).o syscall_$(BITS).o
> obj-y += common.o
> --
> 2.31.1
>

--
Best Regards
Masahiro Yamada

2021-05-25 15:19:33

by Masahiro Yamada

[permalink] [raw]

Subject: Re: [PATCH 2/3] x86/syscalls: Remove -Wno-override-init for syscall tables

On Tue, May 25, 2021 at 3:17 AM Brian Gerst <[email protected]> wrote:
>
> Commit 44fe4895f47c ("Stop filling syscall arrays with *_sys_ni_syscall")
> removes the need for -Wno-override-init, since the table is now filled
> sequentially instead of overriding a default value.
>
> Signed-off-by: Brian Gerst <[email protected]>
> ---

Reviewed-by: Masahiro Yamada <[email protected]>

> arch/x86/entry/Makefile | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/x86/entry/Makefile b/arch/x86/entry/Makefile
> index 08bf95dbc911..94d2843ce80c 100644
> --- a/arch/x86/entry/Makefile
> +++ b/arch/x86/entry/Makefile
> @@ -17,10 +17,6 @@ CFLAGS_syscall_64.o += -fno-stack-protector
> CFLAGS_syscall_32.o += -fno-stack-protector
> CFLAGS_syscall_x32.o += -fno-stack-protector
>
> -CFLAGS_syscall_64.o += $(call cc-option,-Wno-override-init,)
> -CFLAGS_syscall_32.o += $(call cc-option,-Wno-override-init,)
> -CFLAGS_syscall_x32.o += $(call cc-option,-Wno-override-init,)
> -
> obj-y := entry_$(BITS).o thunk_$(BITS).o syscall_$(BITS).o
> obj-y += common.o
>
> --
> 2.31.1
>

--
Best Regards
Masahiro Yamada

2021-05-25 20:20:25

by tip-bot2 for Alexey Makhalov

[permalink] [raw]

Subject: [tip: x86/entry] x86/syscalls: Don't adjust CFLAGS for syscall tables

The following commit has been merged into the x86/entry branch of tip:

Commit-ID: 48f7eee81cd53a94699d28959566b41a9dcac1d9
Gitweb: https://git.kernel.org/tip/48f7eee81cd53a94699d28959566b41a9dcac1d9
Author: Brian Gerst <[email protected]>
AuthorDate: Mon, 24 May 2021 14:17:07 -04:00
Committer: Thomas Gleixner <[email protected]>
CommitterDate: Tue, 25 May 2021 16:59:23 +02:00

x86/syscalls: Don't adjust CFLAGS for syscall tables

The syscall_*.c files only contain data (the syscall tables). There
is no need to adjust CFLAGS for tracing and stack protector since they
contain no code.

Signed-off-by: Brian Gerst <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Link: https://lore.kernel.org/r/[email protected]

---
arch/x86/entry/Makefile | 6 ------
1 file changed, 6 deletions(-)

diff --git a/arch/x86/entry/Makefile b/arch/x86/entry/Makefile
index 94d2843..7fec5dc 100644
--- a/arch/x86/entry/Makefile
+++ b/arch/x86/entry/Makefile
@@ -8,14 +8,8 @@ UBSAN_SANITIZE := n
KCOV_INSTRUMENT := n

CFLAGS_REMOVE_common.o = $(CC_FLAGS_FTRACE)
-CFLAGS_REMOVE_syscall_64.o = $(CC_FLAGS_FTRACE)
-CFLAGS_REMOVE_syscall_32.o = $(CC_FLAGS_FTRACE)
-CFLAGS_REMOVE_syscall_x32.o = $(CC_FLAGS_FTRACE)

CFLAGS_common.o += -fno-stack-protector
-CFLAGS_syscall_64.o += -fno-stack-protector
-CFLAGS_syscall_32.o += -fno-stack-protector
-CFLAGS_syscall_x32.o += -fno-stack-protector

obj-y := entry_$(BITS).o thunk_$(BITS).o syscall_$(BITS).o
obj-y += common.o

2021-05-25 20:21:08

by tip-bot2 for Alexey Makhalov

[permalink] [raw]

Subject: [tip: x86/entry] x86/syscalls: Remove -Wno-override-init for syscall tables

The following commit has been merged into the x86/entry branch of tip:

Commit-ID: fd9e8691f38712892fa2ac73132dcc8b85b07a8f
Gitweb: https://git.kernel.org/tip/fd9e8691f38712892fa2ac73132dcc8b85b07a8f
Author: Brian Gerst <[email protected]>
AuthorDate: Mon, 24 May 2021 14:17:06 -04:00
Committer: Thomas Gleixner <[email protected]>
CommitterDate: Tue, 25 May 2021 16:59:23 +02:00

x86/syscalls: Remove -Wno-override-init for syscall tables

Commit 44fe4895f47c ("Stop filling syscall arrays with *_sys_ni_syscall")
removes the need for -Wno-override-init, since the table is now filled
sequentially instead of overriding a default value.

Signed-off-by: Brian Gerst <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Reviewed-by: Masahiro Yamada <[email protected]>
Link: https://lore.kernel.org/r/[email protected]

---
arch/x86/entry/Makefile | 4 ----
1 file changed, 4 deletions(-)

diff --git a/arch/x86/entry/Makefile b/arch/x86/entry/Makefile
index 08bf95d..94d2843 100644
--- a/arch/x86/entry/Makefile
+++ b/arch/x86/entry/Makefile
@@ -17,10 +17,6 @@ CFLAGS_syscall_64.o += -fno-stack-protector
CFLAGS_syscall_32.o += -fno-stack-protector
CFLAGS_syscall_x32.o += -fno-stack-protector

-CFLAGS_syscall_64.o += $(call cc-option,-Wno-override-init,)
-CFLAGS_syscall_32.o += $(call cc-option,-Wno-override-init,)
-CFLAGS_syscall_x32.o += $(call cc-option,-Wno-override-init,)
-
obj-y := entry_$(BITS).o thunk_$(BITS).o syscall_$(BITS).o
obj-y += common.o