2013-03-13 09:23:16

by Sachin Kamat

Subject: [PATCH 1/1] irqchip: exynos-combiner: Fix checkpatch warnings

Fixes the following warnings:
WARNING: line over 80 characters
WARNING: Prefer pr_warn(... to pr_warning(...

Signed-off-by: Sachin Kamat <[email protected]>
---
drivers/irqchip/exynos-combiner.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c
index e8501db..66b1bf5 100644
--- a/drivers/irqchip/exynos-combiner.c
+++ b/drivers/irqchip/exynos-combiner.c
@@ -229,13 +229,15 @@ void __init combiner_init(void __iomem *combiner_base,
irq_base = irq_alloc_descs(COMBINER_IRQ(0, 0), 1, nr_irq, 0);
if (IS_ERR_VALUE(irq_base)) {
irq_base = COMBINER_IRQ(0, 0);
- pr_warning("%s: irq desc alloc failed. Continuing with %d as linux irq base\n", __func__, irq_base);
+ pr_warn("%s: irq desc alloc failed. "
+ "Continuing with %d as linux irq base\n",
+ __func__, irq_base);
}

combiner_irq_domain = irq_domain_add_legacy(np, nr_irq, irq_base, 0,
&combiner_irq_domain_ops, &combiner_data);
if (WARN_ON(!combiner_irq_domain)) {
- pr_warning("%s: irq domain init failed\n", __func__);
+ pr_warn("%s: irq domain init failed\n", __func__);
return;
}

--
1.7.4.1

2013-04-09 03:04:00

by Sachin Kamat

Subject: Re: [PATCH 1/1] irqchip: exynos-combiner: Fix checkpatch warnings

Hi Kukjin,

On 13 March 2013 14:42, Sachin Kamat <[email protected]> wrote:
> Fixes the following warnings:
> WARNING: line over 80 characters
> WARNING: Prefer pr_warn(... to pr_warning(...
>
> Signed-off-by: Sachin Kamat <[email protected]>
> ---
> drivers/irqchip/exynos-combiner.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c
> index e8501db..66b1bf5 100644
> --- a/drivers/irqchip/exynos-combiner.c
> +++ b/drivers/irqchip/exynos-combiner.c
> @@ -229,13 +229,15 @@ void __init combiner_init(void __iomem *combiner_base,
> irq_base = irq_alloc_descs(COMBINER_IRQ(0, 0), 1, nr_irq, 0);
> if (IS_ERR_VALUE(irq_base)) {
> irq_base = COMBINER_IRQ(0, 0);
> - pr_warning("%s: irq desc alloc failed. Continuing with %d as linux irq base\n", __func__, irq_base);
> + pr_warn("%s: irq desc alloc failed. "
> + "Continuing with %d as linux irq base\n",
> + __func__, irq_base);
> }
>
> combiner_irq_domain = irq_domain_add_legacy(np, nr_irq, irq_base, 0,
> &combiner_irq_domain_ops, &combiner_data);
> if (WARN_ON(!combiner_irq_domain)) {
> - pr_warning("%s: irq domain init failed\n", __func__);
> + pr_warn("%s: irq domain init failed\n", __func__);
> return;
> }
>
> --
> 1.7.4.1
>

ChanHo said you would be picking this patch. Please check.

--
With warm regards,
Sachin

2013-04-09 03:09:09

by Joe Perches

Subject: Re: [PATCH 1/1] irqchip: exynos-combiner: Fix checkpatch warnings

On Tue, 2013-04-09 at 08:33 +0530, Sachin Kamat wrote:
> On 13 March 2013 14:42, Sachin Kamat <[email protected]> wrote:
> > Fixes the following warnings:
> > WARNING: line over 80 characters
> > WARNING: Prefer pr_warn(... to pr_warning(...
> > diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c
[]
> > @@ -229,13 +229,15 @@ void __init combiner_init(void __iomem *combiner_base,
[]
> > - pr_warning("%s: irq desc alloc failed. Continuing with %d as linux irq base\n", __func__, irq_base);
> > + pr_warn("%s: irq desc alloc failed. "
> > + "Continuing with %d as linux irq base\n",
> > + __func__, irq_base);

Please don't split formats.
See Documentation/CodingStyle Chapter 2

pr_warn("%s: irq desc alloc failed. Continuing with %d as linux irq base\n",
__func__, irq_base);

2013-04-09 03:36:14

by Sachin Kamat

Subject: Re: [PATCH 1/1] irqchip: exynos-combiner: Fix checkpatch warnings

On 9 April 2013 08:39, Joe Perches <[email protected]> wrote:
> On Tue, 2013-04-09 at 08:33 +0530, Sachin Kamat wrote:
>> On 13 March 2013 14:42, Sachin Kamat <[email protected]> wrote:
>> > Fixes the following warnings:
>> > WARNING: line over 80 characters
>> > WARNING: Prefer pr_warn(... to pr_warning(...
>> > diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c
> []
>> > @@ -229,13 +229,15 @@ void __init combiner_init(void __iomem *combiner_base,
> []
>> > - pr_warning("%s: irq desc alloc failed. Continuing with %d as linux irq base\n", __func__, irq_base);
>> > + pr_warn("%s: irq desc alloc failed. "
>> > + "Continuing with %d as linux irq base\n",
>> > + __func__, irq_base);
>
> Please don't split formats.
> See Documentation/CodingStyle Chapter 2
>
> pr_warn("%s: irq desc alloc failed. Continuing with %d as linux irq base\n",
> __func__, irq_base);
>
>

Thanks for pointing out. If I didn't split it, it would have exceeded
the 80 column limit. Since there were 2 different sentences, I thought
grepping should not be a problem if split at sentence boundaries.



--
With warm regards,
Sachin

2013-04-09 03:45:36

by Joe Perches

Subject: Re: [PATCH 1/1] irqchip: exynos-combiner: Fix checkpatch warnings

On Tue, 2013-04-09 at 09:06 +0530, Sachin Kamat wrote:
> On 9 April 2013 08:39, Joe Perches <[email protected]> wrote:
> > On Tue, 2013-04-09 at 08:33 +0530, Sachin Kamat wrote:
> >> On 13 March 2013 14:42, Sachin Kamat <[email protected]> wrote:
> >> > Fixes the following warnings:
> >> > WARNING: line over 80 characters
> >> > WARNING: Prefer pr_warn(... to pr_warning(...
> >> > diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c
> > []
> >> > @@ -229,13 +229,15 @@ void __init combiner_init(void __iomem *combiner_base,
> > []
> >> > - pr_warning("%s: irq desc alloc failed. Continuing with %d as linux irq base\n", __func__, irq_base);
> >> > + pr_warn("%s: irq desc alloc failed. "
> >> > + "Continuing with %d as linux irq base\n",
> >> > + __func__, irq_base);
> >
> > Please don't split formats.
> > See Documentation/CodingStyle Chapter 2
> >
> > pr_warn("%s: irq desc alloc failed. Continuing with %d as linux irq base\n",
> > __func__, irq_base);
> >
> >
>
> Thanks for pointing out. If I didn't split it, it would have exceeded
> the 80 column limit.

So?

> Since there were 2 different sentences, I thought
> grepping should not be a problem if split at sentence boundaries.

I think it's OK to split at \n but not necessarily
at a sentence boundary/period.

2013-04-09 03:50:09

by Sachin Kamat

Subject: Re: [PATCH 1/1] irqchip: exynos-combiner: Fix checkpatch warnings

On 9 April 2013 09:15, Joe Perches <[email protected]> wrote:
> On Tue, 2013-04-09 at 09:06 +0530, Sachin Kamat wrote:
>> On 9 April 2013 08:39, Joe Perches <[email protected]> wrote:
>> > On Tue, 2013-04-09 at 08:33 +0530, Sachin Kamat wrote:
>> >> On 13 March 2013 14:42, Sachin Kamat <[email protected]> wrote:
>> >> > Fixes the following warnings:
>> >> > WARNING: line over 80 characters
>> >> > WARNING: Prefer pr_warn(... to pr_warning(...
>> >> > diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c
>> > []
>> >> > @@ -229,13 +229,15 @@ void __init combiner_init(void __iomem *combiner_base,
>> > []
>> >> > - pr_warning("%s: irq desc alloc failed. Continuing with %d as linux irq base\n", __func__, irq_base);
>> >> > + pr_warn("%s: irq desc alloc failed. "
>> >> > + "Continuing with %d as linux irq base\n",
>> >> > + __func__, irq_base);
>> >
>> > Please don't split formats.
>> > See Documentation/CodingStyle Chapter 2
>> >
>> > pr_warn("%s: irq desc alloc failed. Continuing with %d as linux irq base\n",
>> > __func__, irq_base);
>> >
>> >
>>
>> Thanks for pointing out. If I didn't split it, it would have exceeded
>> the 80 column limit.
>
> So?

Removing one would have introduced another :)

>
>> Since there were 2 different sentences, I thought
>> grepping should not be a problem if split at sentence boundaries.
>
> I think it's OK to split at \n but not necessarily
> at a sentence boundary/period.

OK, I will use the format suggested by you and re-submit.
Thanks for reviewing.


--
With warm regards,
Sachin