Since commit d7857c42 (regulator: pfuze100: Use of_get_child_by_name) we get
the following probe failure:
pfuze100-regulator 1-0008: Full layer: 1, Metal layer: 0
pfuze100-regulator 1-0008: FAB: 0, FIN: 0
pfuze100-regulator 1-0008: regulators node not found
pfuze100-regulator: probe of 1-0008 failed with error -22
Revert the offending commit so that we can probe the regulator successfully.
This reverts commit d7857c429475677a6a42d0dce7f870d6241edd41.
Signed-off-by: Fabio Estevam <[email protected]>
---
drivers/regulator/pfuze100-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
index c1cb202..b699d4e 100644
--- a/drivers/regulator/pfuze100-regulator.c
+++ b/drivers/regulator/pfuze100-regulator.c
@@ -254,7 +254,7 @@ static int pfuze_parse_regulators_dt(struct pfuze_chip *chip)
if (!np)
return 0;
- parent = of_get_child_by_name(np, "regulators");
+ parent = of_find_node_by_name(np, "regulators");
if (!parent) {
dev_err(dev, "regulators node not found\n");
return -EINVAL;
--
1.8.1.2
On 18 February 2014 21:20, Fabio Estevam <[email protected]> wrote:
> Since commit d7857c42 (regulator: pfuze100: Use of_get_child_by_name) we get
> the following probe failure:
>
> pfuze100-regulator 1-0008: Full layer: 1, Metal layer: 0
> pfuze100-regulator 1-0008: FAB: 0, FIN: 0
> pfuze100-regulator 1-0008: regulators node not found
> pfuze100-regulator: probe of 1-0008 failed with error -22
>
> Revert the offending commit so that we can probe the regulator successfully.
I wonder what is different in this case from the ones that I already
have working
that is causing this to fail. Can you please tell me which dts file
you have used
so that I can see if the way the node is defined is anything different.
---
With warm regards,
Sachin
On 02/18/2014 01:28 PM, Sachin Kamat wrote:
> On 18 February 2014 21:20, Fabio Estevam <[email protected]> wrote:
>> Since commit d7857c42 (regulator: pfuze100: Use of_get_child_by_name) we get
>> the following probe failure:
>>
>> pfuze100-regulator 1-0008: Full layer: 1, Metal layer: 0
>> pfuze100-regulator 1-0008: FAB: 0, FIN: 0
>> pfuze100-regulator 1-0008: regulators node not found
>> pfuze100-regulator: probe of 1-0008 failed with error -22
>>
>> Revert the offending commit so that we can probe the regulator successfully.
>
> I wonder what is different in this case from the ones that I already
> have working
> that is causing this to fail. Can you please tell me which dts file
> you have used
> so that I can see if the way the node is defined is anything different.
The dts I am using is arch/arm/boot/dts/imx6qdl-sabresd.dtsi, and I
build imx6q-sabresd.dtb from linux-next.
Regards,
Fabio Estevam
On Tue, Feb 18, 2014 at 09:58:52PM +0530, Sachin Kamat wrote:
> On 18 February 2014 21:20, Fabio Estevam <[email protected]> wrote:
> > Since commit d7857c42 (regulator: pfuze100: Use of_get_child_by_name) we get
> > the following probe failure:
> >
> > pfuze100-regulator 1-0008: Full layer: 1, Metal layer: 0
> > pfuze100-regulator 1-0008: FAB: 0, FIN: 0
> > pfuze100-regulator 1-0008: regulators node not found
> > pfuze100-regulator: probe of 1-0008 failed with error -22
> >
> > Revert the offending commit so that we can probe the regulator successfully.
>
> I wonder what is different in this case from the ones that I already
> have working
> that is causing this to fail. Can you please tell me which dts file
> you have used
> so that I can see if the way the node is defined is anything different.
When you change to use of_get_child_by_name(), you should change 'np' to
point to dev->of_node too.
Shawn
On 19 February 2014 07:42, Shawn Guo <[email protected]> wrote:
> On Tue, Feb 18, 2014 at 09:58:52PM +0530, Sachin Kamat wrote:
>> On 18 February 2014 21:20, Fabio Estevam <[email protected]> wrote:
>> > Since commit d7857c42 (regulator: pfuze100: Use of_get_child_by_name) we get
>> > the following probe failure:
>> >
>> > pfuze100-regulator 1-0008: Full layer: 1, Metal layer: 0
>> > pfuze100-regulator 1-0008: FAB: 0, FIN: 0
>> > pfuze100-regulator 1-0008: regulators node not found
>> > pfuze100-regulator: probe of 1-0008 failed with error -22
>> >
>> > Revert the offending commit so that we can probe the regulator successfully.
>>
>> I wonder what is different in this case from the ones that I already
>> have working
>> that is causing this to fail. Can you please tell me which dts file
>> you have used
>> so that I can see if the way the node is defined is anything different.
>
> When you change to use of_get_child_by_name(), you should change 'np' to
> point to dev->of_node too.
Thanks for the tip Shawn. Coincidentally all the ones that I tested
had this (np pointing
to dev->of_node) already. So I happened to miss out on this check.
--
With warm regards,
Sachin