2019-04-16 14:46:08

by Yue Haibing

Subject: [PATCH -next] drm/lima: Make lima_sched_ops static

From: YueHaibing <[email protected]>

Fix sparse warning:

drivers/gpu/drm/lima/lima_sched.c:356:36: warning:
symbol 'lima_sched_ops' was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: YueHaibing <[email protected]>
---
drivers/gpu/drm/lima/lima_sched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/lima/lima_sched.c b/drivers/gpu/drm/lima/lima_sched.c
index 97bd9c1..569f0a95 100644
--- a/drivers/gpu/drm/lima/lima_sched.c
+++ b/drivers/gpu/drm/lima/lima_sched.c
@@ -353,7 +353,7 @@ static void lima_sched_free_job(struct drm_sched_job *job)
kmem_cache_free(pipe->task_slab, task);
}

-const struct drm_sched_backend_ops lima_sched_ops = {
+static const struct drm_sched_backend_ops lima_sched_ops = {
.dependency = lima_sched_dependency,
.run_job = lima_sched_run_job,
.timedout_job = lima_sched_timedout_job,
--
2.7.4

2019-04-17 02:44:29

by Qiang Yu

Subject: Re: [PATCH -next] drm/lima: Make lima_sched_ops static

Thanks, patch is:
Reviewed-by: Qiang Yu <[email protected]>

I'll add a "Fix" tag and push it to drm-misc-next.

Regards,
Qiang

On Tue, Apr 16, 2019 at 10:44 PM Yue Haibing <[email protected]> wrote:
>
> From: YueHaibing <[email protected]>
>
> Fix sparse warning:
>
> drivers/gpu/drm/lima/lima_sched.c:356:36: warning:
> symbol 'lima_sched_ops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/gpu/drm/lima/lima_sched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/lima/lima_sched.c b/drivers/gpu/drm/lima/lima_sched.c
> index 97bd9c1..569f0a95 100644
> --- a/drivers/gpu/drm/lima/lima_sched.c
> +++ b/drivers/gpu/drm/lima/lima_sched.c
> @@ -353,7 +353,7 @@ static void lima_sched_free_job(struct drm_sched_job *job)
> kmem_cache_free(pipe->task_slab, task);
> }
>
> -const struct drm_sched_backend_ops lima_sched_ops = {
> +static const struct drm_sched_backend_ops lima_sched_ops = {
> .dependency = lima_sched_dependency,
> .run_job = lima_sched_run_job,
> .timedout_job = lima_sched_timedout_job,
> --
> 2.7.4
>
>

2019-04-17 13:09:18

by Qiang Yu

Subject: Re: [PATCH -next] drm/lima: Make lima_sched_ops static

Pushed to drm-misc-next.

Thanks,
Qiang

On Tue, Apr 16, 2019 at 10:44 PM Yue Haibing <[email protected]> wrote:
>
> From: YueHaibing <[email protected]>
>
> Fix sparse warning:
>
> drivers/gpu/drm/lima/lima_sched.c:356:36: warning:
> symbol 'lima_sched_ops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/gpu/drm/lima/lima_sched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/lima/lima_sched.c b/drivers/gpu/drm/lima/lima_sched.c
> index 97bd9c1..569f0a95 100644
> --- a/drivers/gpu/drm/lima/lima_sched.c
> +++ b/drivers/gpu/drm/lima/lima_sched.c
> @@ -353,7 +353,7 @@ static void lima_sched_free_job(struct drm_sched_job *job)
> kmem_cache_free(pipe->task_slab, task);
> }
>
> -const struct drm_sched_backend_ops lima_sched_ops = {
> +static const struct drm_sched_backend_ops lima_sched_ops = {
> .dependency = lima_sched_dependency,
> .run_job = lima_sched_run_job,
> .timedout_job = lima_sched_timedout_job,
> --
> 2.7.4
>
>