2023-11-15 15:54:03

by Maxime Ripard

Subject: Re: [PATCH 1/3] kunit: Add a macro to wrap a deferred action function

On Sat, 11 Nov 2023 04:08:26 +0800, David Gow wrote:
> KUnit's deferred action API accepts a void(*)(void *) function pointer
> which is called when the test is exited. However, we very frequently
> want to use existing functions which accept a single pointer, but which
> may not be of type void*. While this is probably dodgy enough to be on
> the wrong side of the C standard, it's been often used for similar
>
> [ ... ]

Reviewed-by: Maxime Ripard <[email protected]>

Thanks!
Maxime

2023-11-15 16:01:21

by Daniel Vetter

Subject: Re: [PATCH 1/3] kunit: Add a macro to wrap a deferred action function

On Wed, 15 Nov 2023 at 16:51, Maxime Ripard <[email protected]> wrote:
>
> On Sat, 11 Nov 2023 04:08:26 +0800, David Gow wrote:
> > KUnit's deferred action API accepts a void(*)(void *) function pointer
> > which is called when the test is exited. However, we very frequently
> > want to use existing functions which accept a single pointer, but which
> > may not be of type void*. While this is probably dodgy enough to be on
> > the wrong side of the C standard, it's been often used for similar
> >
> > [ ... ]
>
> Reviewed-by: Maxime Ripard <[email protected]>

Acked-by: Daniel Vetter <[email protected]> for merging through kunit
tree, since I guess that's the simplest way to land this.

Cheers!
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch