2019-11-06 18:34:51

by Tom Psyborg

[permalink] [raw]
Subject: Re: [PATCH] ath10k: disable cpuidle during downloading firmware.

On 06/11/2019, Kalle Valo <[email protected]> wrote:
> Ikjoon Jang <[email protected]> writes:
>
>> Downloading ath10k firmware needs a large number of IOs and
>> cpuidle's miss predictions make it worse. In the worst case,
>> resume time can be three times longer than the average on sdio.
>>
>> This patch disables cpuidle during firmware downloading by
>> applying PM_QOS_CPU_DMA_LATENCY in ath10k_download_fw().
>>
>> Signed-off-by: Ikjoon Jang <[email protected]>
>
> On what hardware and firmware versions did you test this? I'll add that
> to the commit log.
>
> https://wireless.wiki.kernel.org/en/users/drivers/ath10k/submittingpatches#guidelines
>
> --
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
>
> _______________________________________________
> ath10k mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/ath10k
>

Hi

I've tested this on QCA9880. No issues during firmware download.


2019-11-08 08:34:31

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] ath10k: disable cpuidle during downloading firmware.

Tom Psyborg <[email protected]> writes:

> On 06/11/2019, Kalle Valo <[email protected]> wrote:
>> Ikjoon Jang <[email protected]> writes:
>>
>>> Downloading ath10k firmware needs a large number of IOs and
>>> cpuidle's miss predictions make it worse. In the worst case,
>>> resume time can be three times longer than the average on sdio.
>>>
>>> This patch disables cpuidle during firmware downloading by
>>> applying PM_QOS_CPU_DMA_LATENCY in ath10k_download_fw().
>>>
>>> Signed-off-by: Ikjoon Jang <[email protected]>
>>
>> On what hardware and firmware versions did you test this? I'll add that
>> to the commit log.
>
> I've tested this on QCA9880. No issues during firmware download.

Great, thanks for testing.

--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches