Commit 568494db6809 ("mtd: remove tmio_nand driver") removes the config
MTD_NAND_TMIO and its corresponding driver.
Remove the reference in MTD_SHARPSL_PARTS to that removed config.
Signed-off-by: Lukas Bulwahn <[email protected]>
---
Arnd, please ack.
Miquel, please pick this minor non-urgent patch on top of the commit above.
drivers/mtd/parsers/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/parsers/Kconfig b/drivers/mtd/parsers/Kconfig
index b20e0c38b517..60738edcd5d5 100644
--- a/drivers/mtd/parsers/Kconfig
+++ b/drivers/mtd/parsers/Kconfig
@@ -149,7 +149,7 @@ config MTD_PARSER_TRX
config MTD_SHARPSL_PARTS
tristate "Sharp SL Series NAND flash partition parser"
- depends on MTD_NAND_SHARPSL || MTD_NAND_TMIO || COMPILE_TEST
+ depends on MTD_NAND_SHARPSL || COMPILE_TEST
help
This provides the read-only FTL logic necessary to read the partition
table from the NAND flash of Sharp SL Series (Zaurus) and the MTD
--
2.17.1
On Tue, Mar 7, 2023, at 08:40, Lukas Bulwahn wrote:
> Commit 568494db6809 ("mtd: remove tmio_nand driver") removes the config
> MTD_NAND_TMIO and its corresponding driver.
>
> Remove the reference in MTD_SHARPSL_PARTS to that removed config.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>
> ---
> Arnd, please ack.
> Miquel, please pick this minor non-urgent patch on top of the commit above.
Acked-by: Arnd Bergmann <[email protected]>
Hi Lukas,
[email protected] wrote on Tue, 7 Mar 2023 08:40:38 +0100:
> Commit 568494db6809 ("mtd: remove tmio_nand driver") removes the config
> MTD_NAND_TMIO and its corresponding driver.
>
> Remove the reference in MTD_SHARPSL_PARTS to that removed config.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>
> ---
> Arnd, please ack.
> Miquel, please pick this minor non-urgent patch on top of the commit above.
Actually I guess the SHARPSL driver is not selectable right now, so
this should be sent as part of my next fixes PR. Could you please send
a v2 with a Fixes: tag?
>
> drivers/mtd/parsers/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/parsers/Kconfig b/drivers/mtd/parsers/Kconfig
> index b20e0c38b517..60738edcd5d5 100644
> --- a/drivers/mtd/parsers/Kconfig
> +++ b/drivers/mtd/parsers/Kconfig
> @@ -149,7 +149,7 @@ config MTD_PARSER_TRX
>
> config MTD_SHARPSL_PARTS
> tristate "Sharp SL Series NAND flash partition parser"
> - depends on MTD_NAND_SHARPSL || MTD_NAND_TMIO || COMPILE_TEST
> + depends on MTD_NAND_SHARPSL || COMPILE_TEST
> help
> This provides the read-only FTL logic necessary to read the partition
> table from the NAND flash of Sharp SL Series (Zaurus) and the MTD
Thanks,
Miquèl
On Tue, Mar 7, 2023, at 10:03, Miquel Raynal wrote:
> Hi Lukas,
>
> [email protected] wrote on Tue, 7 Mar 2023 08:40:38 +0100:
>
>> Commit 568494db6809 ("mtd: remove tmio_nand driver") removes the config
>> MTD_NAND_TMIO and its corresponding driver.
>>
>> Remove the reference in MTD_SHARPSL_PARTS to that removed config.
>>
>> Signed-off-by: Lukas Bulwahn <[email protected]>
>> ---
>> Arnd, please ack.
>> Miquel, please pick this minor non-urgent patch on top of the commit above.
>
> Actually I guess the SHARPSL driver is not selectable right now, so
> this should be sent as part of my next fixes PR.
I don't see why not, it just depends on 'ARCH_PXA||COMPILE_TEST' and
should work fine with CONFIG_MACH_SPITZ PDAs.
Arnd
Hi Arnd,
[email protected] wrote on Tue, 07 Mar 2023 11:26:48 +0100:
> On Tue, Mar 7, 2023, at 10:03, Miquel Raynal wrote:
> > Hi Lukas,
> >
> > [email protected] wrote on Tue, 7 Mar 2023 08:40:38 +0100:
> >
> >> Commit 568494db6809 ("mtd: remove tmio_nand driver") removes the config
> >> MTD_NAND_TMIO and its corresponding driver.
> >>
> >> Remove the reference in MTD_SHARPSL_PARTS to that removed config.
> >>
> >> Signed-off-by: Lukas Bulwahn <[email protected]>
> >> ---
> >> Arnd, please ack.
> >> Miquel, please pick this minor non-urgent patch on top of the commit above.
> >
> > Actually I guess the SHARPSL driver is not selectable right now, so
> > this should be sent as part of my next fixes PR.
>
> I don't see why not, it just depends on 'ARCH_PXA||COMPILE_TEST' and
> should work fine with CONFIG_MACH_SPITZ PDAs.
Sorry, I overlooked the diff, indeed there is nothing broken, so I'll
queue it to nand/next. I thought MTD_SHARPSL_PARTS was not selectable
anymore without COMPILE_TEST, which would have been problematic.
Fixes tag still welcome though :)
Thanks,
Miquèl
On Tue, Mar 7, 2023 at 11:38 AM Miquel Raynal <[email protected]> wrote:
>
> Hi Arnd,
>
> [email protected] wrote on Tue, 07 Mar 2023 11:26:48 +0100:
>
> > On Tue, Mar 7, 2023, at 10:03, Miquel Raynal wrote:
> > > Hi Lukas,
> > >
> > > [email protected] wrote on Tue, 7 Mar 2023 08:40:38 +0100:
> > >
> > >> Commit 568494db6809 ("mtd: remove tmio_nand driver") removes the config
> > >> MTD_NAND_TMIO and its corresponding driver.
> > >>
> > >> Remove the reference in MTD_SHARPSL_PARTS to that removed config.
> > >>
> > >> Signed-off-by: Lukas Bulwahn <[email protected]>
> > >> ---
> > >> Arnd, please ack.
> > >> Miquel, please pick this minor non-urgent patch on top of the commit above.
> > >
> > > Actually I guess the SHARPSL driver is not selectable right now, so
> > > this should be sent as part of my next fixes PR.
> >
> > I don't see why not, it just depends on 'ARCH_PXA||COMPILE_TEST' and
> > should work fine with CONFIG_MACH_SPITZ PDAs.
>
> Sorry, I overlooked the diff, indeed there is nothing broken, so I'll
> queue it to nand/next. I thought MTD_SHARPSL_PARTS was not selectable
> anymore without COMPILE_TEST, which would have been problematic.
>
> Fixes tag still welcome though :)
>
Arnd's commit is not broken. It does what Arnd writes in his commit
message what it should do.
And this patch is just a clean-up that removes references, but it is
just "stylistic" and reduces the complexity of Kconfig dependency
definitions for non-existing config symbols. I do not see that this
patch fixes Arnd's patch. It is just a clean-up with a reference to
Arnd's patch to understand why this clean up can be done now.
If you REALLY want the Fixes: tag, I can sure add it. But, I do not
claim that I am fixing anything here; nothing was broken in the first
place. The reference to the commit of interest is in the commit
message, and anyone can follow or extract the information if they are
interested.
So, please keep this patch in the queue for nand/next.
Lukas
> Thanks,
> Miquèl
Hi Lukas,
[email protected] wrote on Tue, 7 Mar 2023 11:58:07 +0100:
> On Tue, Mar 7, 2023 at 11:38 AM Miquel Raynal <[email protected]> wrote:
> >
> > Hi Arnd,
> >
> > [email protected] wrote on Tue, 07 Mar 2023 11:26:48 +0100:
> >
> > > On Tue, Mar 7, 2023, at 10:03, Miquel Raynal wrote:
> > > > Hi Lukas,
> > > >
> > > > [email protected] wrote on Tue, 7 Mar 2023 08:40:38 +0100:
> > > >
> > > >> Commit 568494db6809 ("mtd: remove tmio_nand driver") removes the config
> > > >> MTD_NAND_TMIO and its corresponding driver.
> > > >>
> > > >> Remove the reference in MTD_SHARPSL_PARTS to that removed config.
> > > >>
> > > >> Signed-off-by: Lukas Bulwahn <[email protected]>
> > > >> ---
> > > >> Arnd, please ack.
> > > >> Miquel, please pick this minor non-urgent patch on top of the commit above.
> > > >
> > > > Actually I guess the SHARPSL driver is not selectable right now, so
> > > > this should be sent as part of my next fixes PR.
> > >
> > > I don't see why not, it just depends on 'ARCH_PXA||COMPILE_TEST' and
> > > should work fine with CONFIG_MACH_SPITZ PDAs.
> >
> > Sorry, I overlooked the diff, indeed there is nothing broken, so I'll
> > queue it to nand/next. I thought MTD_SHARPSL_PARTS was not selectable
> > anymore without COMPILE_TEST, which would have been problematic.
> >
> > Fixes tag still welcome though :)
> >
>
> Arnd's commit is not broken. It does what Arnd writes in his commit
> message what it should do.
>
> And this patch is just a clean-up that removes references, but it is
> just "stylistic" and reduces the complexity of Kconfig dependency
> definitions for non-existing config symbols. I do not see that this
> patch fixes Arnd's patch. It is just a clean-up with a reference to
> Arnd's patch to understand why this clean up can be done now.
>
> If you REALLY want the Fixes: tag, I can sure add it. But, I do not
> claim that I am fixing anything here; nothing was broken in the first
> place. The reference to the commit of interest is in the commit
> message, and anyone can follow or extract the information if they are
> interested.
>
> So, please keep this patch in the queue for nand/next.
Wow, so much arguing just for a Fixes tag.
It is not broken, I know, but it is somehow incomplete as it creates a
stalled Kconfig symbol. And you come-in and fix the situation by
dropping the remaining symbol. So for me it's a fix, no matter how
deeply bogus (or not) the original commit was. It's not an insult, it's
a tag that allows easy parsing. Anyway, that's meaningless. I'll take
it like that.
Thanks,
Miquèl
On Tue, 2023-03-07 at 07:40:38 UTC, Lukas Bulwahn wrote:
> Commit 568494db6809 ("mtd: remove tmio_nand driver") removes the config
> MTD_NAND_TMIO and its corresponding driver.
>
> Remove the reference in MTD_SHARPSL_PARTS to that removed config.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>
> Acked-by: Arnd Bergmann <[email protected]>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel