2021-08-24 09:04:52

by Nghia Le

Subject: [PATCH] perf tools: Add missing newline at the end of file

Add missing newline at the end of file parse-sublevel-options.h.
Thus removing relevant warning reported by checkpatch.

Signed-off-by: Nghia Le <[email protected]>
---
tools/perf/util/parse-sublevel-options.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/parse-sublevel-options.h b/tools/perf/util/parse-sublevel-options.h
index 9b9efcc2aaad..578b18ef03bb 100644
--- a/tools/perf/util/parse-sublevel-options.h
+++ b/tools/perf/util/parse-sublevel-options.h
@@ -8,4 +8,4 @@ struct sublevel_option {

int perf_parse_sublevel_options(const char *str, struct sublevel_option *opts);

-#endif
\ No newline at end of file
+#endif
--
2.25.1

2021-08-24 14:40:14

by Lukas Bulwahn

Subject: Re: [PATCH] perf tools: Add missing newline at the end of file

On Tue, Aug 24, 2021 at 11:00 AM Nghia Le <[email protected]> wrote:
>
> Add missing newline at the end of file parse-sublevel-options.h.
> Thus removing relevant warning reported by checkpatch.
>
> Signed-off-by: Nghia Le <[email protected]>

Reviewed-by: Lukas Bulwahn <[email protected]>

This addresses the only instance of a "no newline at the end of the
file" throughout the kernel tree.

This is part of a larger effort to identify all rules that checkpatch
warns about and that are never false positives (compared to the many
rules in checkpatch that are heuristics or are known to be ignored by
the current development community and hence, cause many false
positives). We could use such rules to be enforced in the submission
process.

Lukas
Lukas
> ---
> tools/perf/util/parse-sublevel-options.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/parse-sublevel-options.h b/tools/perf/util/parse-sublevel-options.h
> index 9b9efcc2aaad..578b18ef03bb 100644
> --- a/tools/perf/util/parse-sublevel-options.h
> +++ b/tools/perf/util/parse-sublevel-options.h
> @@ -8,4 +8,4 @@ struct sublevel_option {
>
> int perf_parse_sublevel_options(const char *str, struct sublevel_option *opts);
>
> -#endif
> \ No newline at end of file
> +#endif
> --
> 2.25.1
>

2021-08-24 18:05:45

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf tools: Add missing newline at the end of file

Em Tue, Aug 24, 2021 at 04:37:19PM +0200, Lukas Bulwahn escreveu:
> On Tue, Aug 24, 2021 at 11:00 AM Nghia Le <[email protected]> wrote:
> >
> > Add missing newline at the end of file parse-sublevel-options.h.
> > Thus removing relevant warning reported by checkpatch.
> >
> > Signed-off-by: Nghia Le <[email protected]>
>
> Reviewed-by: Lukas Bulwahn <[email protected]>


Thanks, applied.

- Arnaldo


> This addresses the only instance of a "no newline at the end of the
> file" throughout the kernel tree.
>
> This is part of a larger effort to identify all rules that checkpatch
> warns about and that are never false positives (compared to the many
> rules in checkpatch that are heuristics or are known to be ignored by
> the current development community and hence, cause many false
> positives). We could use such rules to be enforced in the submission
> process.
>
> Lukas
> Lukas
> > ---
> > tools/perf/util/parse-sublevel-options.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/parse-sublevel-options.h b/tools/perf/util/parse-sublevel-options.h
> > index 9b9efcc2aaad..578b18ef03bb 100644
> > --- a/tools/perf/util/parse-sublevel-options.h
> > +++ b/tools/perf/util/parse-sublevel-options.h
> > @@ -8,4 +8,4 @@ struct sublevel_option {
> >
> > int perf_parse_sublevel_options(const char *str, struct sublevel_option *opts);
> >
> > -#endif
> > \ No newline at end of file
> > +#endif
> > --
> > 2.25.1
> >

--

- Arnaldo