Fix all kernel-doc warnings in vfs.c:
vfs.c:54: warning: Function parameter or member 'parent' not described in 'ksmbd_vfs_lock_parent'
vfs.c:54: warning: Function parameter or member 'child' not described in 'ksmbd_vfs_lock_parent'
vfs.c:54: warning: No description found for return value of 'ksmbd_vfs_lock_parent'
vfs.c:372: warning: Function parameter or member 'fp' not described in 'ksmbd_vfs_read'
vfs.c:372: warning: Excess function parameter 'fid' description in 'ksmbd_vfs_read'
vfs.c:489: warning: Function parameter or member 'fp' not described in 'ksmbd_vfs_write'
vfs.c:489: warning: Excess function parameter 'fid' description in 'ksmbd_vfs_write'
vfs.c:555: warning: Function parameter or member 'path' not described in 'ksmbd_vfs_getattr'
vfs.c:555: warning: Function parameter or member 'stat' not described in 'ksmbd_vfs_getattr'
vfs.c:555: warning: Excess function parameter 'work' description in 'ksmbd_vfs_getattr'
vfs.c:555: warning: Excess function parameter 'fid' description in 'ksmbd_vfs_getattr'
vfs.c:555: warning: Excess function parameter 'attrs' description in 'ksmbd_vfs_getattr'
vfs.c:572: warning: Function parameter or member 'p_id' not described in 'ksmbd_vfs_fsync'
vfs.c:595: warning: Function parameter or member 'work' not described in 'ksmbd_vfs_remove_file'
vfs.c:595: warning: Function parameter or member 'path' not described in 'ksmbd_vfs_remove_file'
vfs.c:595: warning: Excess function parameter 'name' description in 'ksmbd_vfs_remove_file'
vfs.c:633: warning: Function parameter or member 'work' not described in 'ksmbd_vfs_link'
vfs.c:805: warning: Function parameter or member 'fp' not described in 'ksmbd_vfs_truncate'
vfs.c:805: warning: Excess function parameter 'fid' description in 'ksmbd_vfs_truncate'
vfs.c:846: warning: Excess function parameter 'size' description in 'ksmbd_vfs_listxattr'
vfs.c:953: warning: Function parameter or member 'option' not described in 'ksmbd_vfs_set_fadvise'
vfs.c:953: warning: Excess function parameter 'options' description in 'ksmbd_vfs_set_fadvise'
vfs.c:1167: warning: Function parameter or member 'um' not described in 'ksmbd_vfs_lookup_in_dir'
vfs.c:1203: warning: Function parameter or member 'work' not described in 'ksmbd_vfs_kern_path_locked'
vfs.c:1641: warning: No description found for return value of 'ksmbd_vfs_init_kstat'
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Namjae Jeon <[email protected]>
Cc: Steve French <[email protected]>
Cc: Sergey Senozhatsky <[email protected]>
Cc: Tom Talpey <[email protected]>
Cc: [email protected]
---
fs/smb/server/vfs.c | 28 ++++++++++++++++++----------
1 file changed, 18 insertions(+), 10 deletions(-)
diff -- a/fs/smb/server/vfs.c b/fs/smb/server/vfs.c
--- a/fs/smb/server/vfs.c
+++ b/fs/smb/server/vfs.c
@@ -49,6 +49,10 @@ static void ksmbd_vfs_inherit_owner(stru
/**
* ksmbd_vfs_lock_parent() - lock parent dentry if it is stable
+ * @parent: parent dentry
+ * @child: child dentry
+ *
+ * Returns: %0 on success, %-ENOENT if the parent dentry is not stable
*/
int ksmbd_vfs_lock_parent(struct dentry *parent, struct dentry *child)
{
@@ -360,7 +364,7 @@ out:
/**
* ksmbd_vfs_read() - vfs helper for smb file read
* @work: smb work
- * @fid: file id of open file
+ * @fp: ksmbd file pointer
* @count: read byte count
* @pos: file pos
* @rbuf: read data buffer
@@ -474,7 +478,7 @@ out:
/**
* ksmbd_vfs_write() - vfs helper for smb file write
* @work: work
- * @fid: file id of open file
+ * @fp: ksmbd file pointer
* @buf: buf containing data for writing
* @count: read byte count
* @pos: file pos
@@ -545,10 +549,8 @@ out:
/**
* ksmbd_vfs_getattr() - vfs helper for smb getattr
- * @work: work
- * @fid: file id of open file
- * @attrs: inode attributes
- *
+ * @path: path of dentry
+ * @stat: pointer to returned kernel stat structure
* Return: 0 on success, otherwise error
*/
int ksmbd_vfs_getattr(const struct path *path, struct kstat *stat)
@@ -565,6 +567,7 @@ int ksmbd_vfs_getattr(const struct path
* ksmbd_vfs_fsync() - vfs helper for smb fsync
* @work: work
* @fid: file id of open file
+ * @p_id: persistent file id
*
* Return: 0 on success, otherwise error
*/
@@ -587,7 +590,8 @@ int ksmbd_vfs_fsync(struct ksmbd_work *w
/**
* ksmbd_vfs_remove_file() - vfs helper for smb rmdir or unlink
- * @name: directory or file name that is relative to share
+ * @work: work
+ * @path: path of dentry
*
* Return: 0 on success, otherwise error
*/
@@ -623,6 +627,7 @@ out_err:
/**
* ksmbd_vfs_link() - vfs helper for creating smb hardlink
+ * @work: work
* @oldname: source file name
* @newname: hardlink name that is relative to share
*
@@ -795,7 +800,7 @@ revert_fsids:
/**
* ksmbd_vfs_truncate() - vfs helper for smb file truncate
* @work: work
- * @fid: file id of old file
+ * @fp: ksmbd file pointer
* @size: truncate to given size
*
* Return: 0 on success, otherwise error
@@ -838,7 +843,6 @@ int ksmbd_vfs_truncate(struct ksmbd_work
* ksmbd_vfs_listxattr() - vfs helper for smb list extended attributes
* @dentry: dentry of file for listing xattrs
* @list: destination buffer
- * @size: destination buffer length
*
* Return: xattr list length on success, otherwise error
*/
@@ -947,7 +951,7 @@ int ksmbd_vfs_setxattr(struct mnt_idmap
/**
* ksmbd_vfs_set_fadvise() - convert smb IO caching options to linux options
* @filp: file pointer for IO
- * @options: smb IO options
+ * @option: smb IO options
*/
void ksmbd_vfs_set_fadvise(struct file *filp, __le32 option)
{
@@ -1159,6 +1163,7 @@ static bool __caseless_lookup(struct dir
* @dir: path info
* @name: filename to lookup
* @namelen: filename length
+ * @um: &struct unicode_map to use
*
* Return: 0 on success, otherwise error
*/
@@ -1189,6 +1194,7 @@ static int ksmbd_vfs_lookup_in_dir(const
/**
* ksmbd_vfs_kern_path_locked() - lookup a file and get path info
+ * @work: work
* @name: file path that is relative to share
* @flags: lookup flags
* @parent_path: if lookup succeed, return parent_path info
@@ -1636,6 +1642,8 @@ int ksmbd_vfs_get_dos_attrib_xattr(struc
* ksmbd_vfs_init_kstat() - convert unix stat information to smb stat format
* @p: destination buffer
* @ksmbd_kstat: ksmbd kstat wrapper
+ *
+ * Returns: pointer to the converted &struct file_directory_info
*/
void *ksmbd_vfs_init_kstat(char **p, struct ksmbd_kstat *ksmbd_kstat)
{
2023-12-16 12:28 GMT+09:00, Randy Dunlap <[email protected]>:
> Fix all kernel-doc warnings in vfs.c:
>
> vfs.c:54: warning: Function parameter or member 'parent' not described in
> 'ksmbd_vfs_lock_parent'
> vfs.c:54: warning: Function parameter or member 'child' not described in
> 'ksmbd_vfs_lock_parent'
> vfs.c:54: warning: No description found for return value of
> 'ksmbd_vfs_lock_parent'
> vfs.c:372: warning: Function parameter or member 'fp' not described in
> 'ksmbd_vfs_read'
> vfs.c:372: warning: Excess function parameter 'fid' description in
> 'ksmbd_vfs_read'
> vfs.c:489: warning: Function parameter or member 'fp' not described in
> 'ksmbd_vfs_write'
> vfs.c:489: warning: Excess function parameter 'fid' description in
> 'ksmbd_vfs_write'
> vfs.c:555: warning: Function parameter or member 'path' not described in
> 'ksmbd_vfs_getattr'
> vfs.c:555: warning: Function parameter or member 'stat' not described in
> 'ksmbd_vfs_getattr'
> vfs.c:555: warning: Excess function parameter 'work' description in
> 'ksmbd_vfs_getattr'
> vfs.c:555: warning: Excess function parameter 'fid' description in
> 'ksmbd_vfs_getattr'
> vfs.c:555: warning: Excess function parameter 'attrs' description in
> 'ksmbd_vfs_getattr'
> vfs.c:572: warning: Function parameter or member 'p_id' not described in
> 'ksmbd_vfs_fsync'
> vfs.c:595: warning: Function parameter or member 'work' not described in
> 'ksmbd_vfs_remove_file'
> vfs.c:595: warning: Function parameter or member 'path' not described in
> 'ksmbd_vfs_remove_file'
> vfs.c:595: warning: Excess function parameter 'name' description in
> 'ksmbd_vfs_remove_file'
> vfs.c:633: warning: Function parameter or member 'work' not described in
> 'ksmbd_vfs_link'
> vfs.c:805: warning: Function parameter or member 'fp' not described in
> 'ksmbd_vfs_truncate'
> vfs.c:805: warning: Excess function parameter 'fid' description in
> 'ksmbd_vfs_truncate'
> vfs.c:846: warning: Excess function parameter 'size' description in
> 'ksmbd_vfs_listxattr'
> vfs.c:953: warning: Function parameter or member 'option' not described in
> 'ksmbd_vfs_set_fadvise'
> vfs.c:953: warning: Excess function parameter 'options' description in
> 'ksmbd_vfs_set_fadvise'
> vfs.c:1167: warning: Function parameter or member 'um' not described in
> 'ksmbd_vfs_lookup_in_dir'
> vfs.c:1203: warning: Function parameter or member 'work' not described in
> 'ksmbd_vfs_kern_path_locked'
> vfs.c:1641: warning: No description found for return value of
> 'ksmbd_vfs_init_kstat'
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Namjae Jeon <[email protected]>
> Cc: Steve French <[email protected]>
> Cc: Sergey Senozhatsky <[email protected]>
> Cc: Tom Talpey <[email protected]>
> Cc: [email protected]
Acked-by: Namjae Jeon <[email protected]>
Applied it to #ksmbd-for-next-next.
Thanks for your patch!