2021-09-12 02:21:18

by Mike Galbraith

Subject: ksmbd,transport_rdma.c: Don't include rwlock.h directly

rwlock.h specifically asks to not be included directly.

In fact, the proper spinlock.h include isn't needed either,
it comes with the huge pile that kthread.h ends up pulling
in, so just drop it entirely.

Signed-off-by: Mike Galbraith <[email protected]>
---
fs/ksmbd/transport_rdma.c | 1 -
1 file changed, 1 deletion(-)

--- a/fs/ksmbd/transport_rdma.c
+++ b/fs/ksmbd/transport_rdma.c
@@ -20,7 +20,6 @@
#define SUBMOD_NAME "smb_direct"

#include <linux/kthread.h>
-#include <linux/rwlock.h>
#include <linux/list.h>
#include <linux/mempool.h>
#include <linux/highmem.h>

2021-09-12 02:24:07

by Mike Galbraith

Subject: Re: ksmbd,transport_rdma.c: Don't include rwlock.h directly

typing hard.. Thag forget type [patch]

On Sun, 2021-09-12 at 04:19 +0200, Mike Galbraith wrote:
>
> rwlock.h specifically asks to not be included directly.
>
> In fact, the proper spinlock.h include isn't needed either,
> it comes with the huge pile that kthread.h ends up pulling
> in, so just drop it entirely.
>
> Signed-off-by: Mike Galbraith <[email protected]>
> ---
>  fs/ksmbd/transport_rdma.c |    1 -
>  1 file changed, 1 deletion(-)
>
> --- a/fs/ksmbd/transport_rdma.c
> +++ b/fs/ksmbd/transport_rdma.c
> @@ -20,7 +20,6 @@
>  #define SUBMOD_NAME    "smb_direct"
>
>  #include <linux/kthread.h>
> -#include <linux/rwlock.h>
>  #include <linux/list.h>
>  #include <linux/mempool.h>
>  #include <linux/highmem.h>
>

2021-09-12 03:04:24

by Namjae Jeon

Subject: Re: ksmbd,transport_rdma.c: Don't include rwlock.h directly

2021-09-12 11:23 GMT+09:00, Mike Galbraith <[email protected]>:
> typing hard.. Thag forget type [patch]
I will apply this patch, Thanks for your patch!
>
> On Sun, 2021-09-12 at 04:19 +0200, Mike Galbraith wrote:
>>
>> rwlock.h specifically asks to not be included directly.
>>
>> In fact, the proper spinlock.h include isn't needed either,
>> it comes with the huge pile that kthread.h ends up pulling
>> in, so just drop it entirely.
>>
>> Signed-off-by: Mike Galbraith <[email protected]>
>> ---
>> fs/ksmbd/transport_rdma.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> --- a/fs/ksmbd/transport_rdma.c
>> +++ b/fs/ksmbd/transport_rdma.c
>> @@ -20,7 +20,6 @@
>> #define SUBMOD_NAME "smb_direct"
>>
>> #include <linux/kthread.h>
>> -#include <linux/rwlock.h>
>> #include <linux/list.h>
>> #include <linux/mempool.h>
>> #include <linux/highmem.h>
>>
>
>