2022-03-30 18:24:00

by Alistair Francis

[permalink] [raw]
Subject: [PATCH v20 0/4] Add support for the silergy,sy7636a

v20:

- Rebase on master

- Remove merged patches

- Fixup Kconfig selection based on previous discussions

v19:

- Rebase on linux-next

v18:

- Rebase

v17:

- Rebase and fix build issues

v16:

- Improve vdd regulator comments

v15:

- Address comments on the patches

v14:

- Merge the thermal driver and hwmon

v13:

- Address comments on thermal driver

- Rebase on master (without other patches)

v12:

- Rebase

v11:

- Address comments on hwmon

- Improve "mfd: simple-mfd-i2c: Add a Kconfig name" commit message

v10:

- Use dev_get_regmap() instead of dev_get_drvdata()

v9:

- Convert to use the simple-mfd-i2c instead



Alistair Francis (4):

mfd: silergy,sy7636a: Add config option

ARM: imx_v6_v7_defconfig: Enable silergy,sy7636a

ARM: dts: imx7d-remarkable2: Enable silergy,sy7636a

ARM: dts: imx7d-remarkable2: Enable lcdif



arch/arm/boot/dts/imx7d-remarkable2.dts | 136 ++++++++++++++++++++++++

arch/arm/configs/imx_v6_v7_defconfig | 3 +

drivers/hwmon/Kconfig | 1 +

drivers/mfd/Kconfig | 12 ++-

drivers/regulator/Kconfig | 1 +

5 files changed, 152 insertions(+), 1 deletion(-)



--

2.35.1




2022-03-30 18:40:54

by Alistair Francis

[permalink] [raw]
Subject: [PATCH v20 1/4] mfd: silergy,sy7636a: Add config option

Add a specific MFD_SY7636A config option.

As part of this change we can use MFD_SY7636A as a dependency for all
SY7636a components and also remove the name from MFD_SIMPLE_MFD_I2C as
it no longer needs to be selectable.

Signed-off-by: Alistair Francis <[email protected]>
---
drivers/hwmon/Kconfig | 1 +
drivers/mfd/Kconfig | 12 +++++++++++-
drivers/regulator/Kconfig | 1 +
3 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 68a8a27ab3b7..74b60d24e740 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -1693,6 +1693,7 @@ config SENSORS_SIS5595

config SENSORS_SY7636A
tristate "Silergy SY7636A"
+ depends on MFD_SY7636A
help
If you say yes here you get support for the thermistor readout of
the Silergy SY7636A PMIC.
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 3b59456f5545..c47cb755757b 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -1095,6 +1095,16 @@ config MFD_SPMI_PMIC
Say M here if you want to include support for the SPMI PMIC
series as a module. The module will be called "qcom-spmi-pmic".

+config MFD_SY7636A
+ tristate "Silergy SY7636A voltage regulator"
+ depends on I2C
+ select MFD_SIMPLE_MFD_I2C
+ help
+ Enable support for Silergy SY7636A voltage regulator.
+
+ To enable support for building sub-devices as modules,
+ choose M here.
+
config MFD_RDC321X
tristate "RDC R-321x southbridge"
select MFD_CORE
@@ -1202,7 +1212,7 @@ config MFD_SI476X_CORE
module will be called si476x-core.

config MFD_SIMPLE_MFD_I2C
- tristate "Simple Multi-Functional Device support (I2C)"
+ tristate
depends on I2C
select MFD_CORE
select REGMAP_I2C
diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index 5ef2306fce04..c8ce6e5eea24 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -1219,6 +1219,7 @@ config REGULATOR_STW481X_VMMC

config REGULATOR_SY7636A
tristate "Silergy SY7636A voltage regulator"
+ depends on MFD_SY7636A
help
This driver supports Silergy SY3686A voltage regulator.

--
2.35.1

2022-03-31 04:08:49

by Alistair Francis

[permalink] [raw]
Subject: [PATCH v20 2/4] ARM: imx_v6_v7_defconfig: Enable silergy,sy7636a

Enable the silergy,sy7636a and silergy,sy7636a-regulator for the
reMarkable2.

Signed-off-by: Alistair Francis <[email protected]>
---
arch/arm/configs/imx_v6_v7_defconfig | 3 +++
1 file changed, 3 insertions(+)

diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index f7498df08dfe..81fe604bf4ec 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -223,6 +223,7 @@ CONFIG_RN5T618_POWER=m
CONFIG_SENSORS_MC13783_ADC=y
CONFIG_SENSORS_GPIO_FAN=y
CONFIG_SENSORS_IIO_HWMON=y
+CONFIG_SENSORS_SY7636A=y
CONFIG_THERMAL_STATISTICS=y
CONFIG_THERMAL_WRITABLE_TRIPS=y
CONFIG_CPU_THERMAL=y
@@ -238,6 +239,7 @@ CONFIG_MFD_DA9062=y
CONFIG_MFD_DA9063=y
CONFIG_MFD_MC13XXX_SPI=y
CONFIG_MFD_MC13XXX_I2C=y
+CONFIG_MFD_SY7636A=y
CONFIG_MFD_RN5T618=y
CONFIG_MFD_STMPE=y
CONFIG_REGULATOR_FIXED_VOLTAGE=y
@@ -251,6 +253,7 @@ CONFIG_REGULATOR_MC13783=y
CONFIG_REGULATOR_MC13892=y
CONFIG_REGULATOR_PFUZE100=y
CONFIG_REGULATOR_RN5T618=y
+CONFIG_REGULATOR_SY7636A=y
CONFIG_RC_CORE=y
CONFIG_RC_DEVICES=y
CONFIG_IR_GPIO_CIR=y
--
2.35.1

2022-03-31 04:15:18

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH v20 1/4] mfd: silergy,sy7636a: Add config option

On 3/30/22 02:41, Alistair Francis wrote:
> Add a specific MFD_SY7636A config option.
>
> As part of this change we can use MFD_SY7636A as a dependency for all
> SY7636a components and also remove the name from MFD_SIMPLE_MFD_I2C as
> it no longer needs to be selectable.
>
> Signed-off-by: Alistair Francis <[email protected]>

Reviewed-by: Guenter Roeck <[email protected]>

> ---
> drivers/hwmon/Kconfig | 1 +
> drivers/mfd/Kconfig | 12 +++++++++++-
> drivers/regulator/Kconfig | 1 +
> 3 files changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 68a8a27ab3b7..74b60d24e740 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -1693,6 +1693,7 @@ config SENSORS_SIS5595
>
> config SENSORS_SY7636A
> tristate "Silergy SY7636A"
> + depends on MFD_SY7636A
> help
> If you say yes here you get support for the thermistor readout of
> the Silergy SY7636A PMIC.
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 3b59456f5545..c47cb755757b 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1095,6 +1095,16 @@ config MFD_SPMI_PMIC
> Say M here if you want to include support for the SPMI PMIC
> series as a module. The module will be called "qcom-spmi-pmic".
>
> +config MFD_SY7636A
> + tristate "Silergy SY7636A voltage regulator"
> + depends on I2C
> + select MFD_SIMPLE_MFD_I2C
> + help
> + Enable support for Silergy SY7636A voltage regulator.
> +
> + To enable support for building sub-devices as modules,
> + choose M here.
> +
> config MFD_RDC321X
> tristate "RDC R-321x southbridge"
> select MFD_CORE
> @@ -1202,7 +1212,7 @@ config MFD_SI476X_CORE
> module will be called si476x-core.
>
> config MFD_SIMPLE_MFD_I2C
> - tristate "Simple Multi-Functional Device support (I2C)"
> + tristate
> depends on I2C
> select MFD_CORE
> select REGMAP_I2C
> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
> index 5ef2306fce04..c8ce6e5eea24 100644
> --- a/drivers/regulator/Kconfig
> +++ b/drivers/regulator/Kconfig
> @@ -1219,6 +1219,7 @@ config REGULATOR_STW481X_VMMC
>
> config REGULATOR_SY7636A
> tristate "Silergy SY7636A voltage regulator"
> + depends on MFD_SY7636A
> help
> This driver supports Silergy SY3686A voltage regulator.
>

2022-03-31 04:34:32

by Alistair Francis

[permalink] [raw]
Subject: [PATCH v20 3/4] ARM: dts: imx7d-remarkable2: Enable silergy,sy7636a

Enable the silergy,sy7636a and silergy,sy7636a-regulator on the
reMarkable2.

Signed-off-by: Alistair Francis <[email protected]>
---
arch/arm/boot/dts/imx7d-remarkable2.dts | 62 +++++++++++++++++++++++++
1 file changed, 62 insertions(+)

diff --git a/arch/arm/boot/dts/imx7d-remarkable2.dts b/arch/arm/boot/dts/imx7d-remarkable2.dts
index a2a91bfdd98e..99ac0d242936 100644
--- a/arch/arm/boot/dts/imx7d-remarkable2.dts
+++ b/arch/arm/boot/dts/imx7d-remarkable2.dts
@@ -22,6 +22,27 @@ memory@80000000 {
reg = <0x80000000 0x40000000>;
};

+ thermal-zones {
+ epd-thermal {
+ thermal-sensors = <&epd_pmic>;
+ polling-delay-passive = <30000>;
+ polling-delay = <30000>;
+ trips {
+ trip0 {
+ temperature = <49000>;
+ hysteresis = <2000>;
+ type = "passive";
+ };
+
+ trip1 {
+ temperature = <50000>;
+ hysteresis = <2000>;
+ type = "critical";
+ };
+ };
+ };
+ };
+
reg_brcm: regulator-brcm {
compatible = "regulator-fixed";
regulator-name = "brcm_reg";
@@ -84,6 +105,33 @@ wacom_digitizer: digitizer@9 {
};
};

+&i2c4 {
+ clock-frequency = <100000>;
+ pinctrl-names = "default", "sleep";
+ pinctrl-0 = <&pinctrl_i2c4>;
+ pinctrl-1 = <&pinctrl_i2c4>;
+ status = "okay";
+
+ epd_pmic: sy7636a@62 {
+ compatible = "silergy,sy7636a";
+ reg = <0x62>;
+ status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_epdpmic>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ #thermal-sensor-cells = <0>;
+
+ epd-pwr-good-gpios = <&gpio6 21 GPIO_ACTIVE_HIGH>;
+ regulators {
+ reg_epdpmic: vcom {
+ regulator-name = "vcom";
+ regulator-boot-on;
+ };
+ };
+ };
+};
+
&snvs_pwrkey {
status = "okay";
};
@@ -177,6 +225,13 @@ MX7D_PAD_SAI1_TX_BCLK__GPIO6_IO13 0x14
>;
};

+ pinctrl_epdpmic: epdpmicgrp {
+ fsl,pins = <
+ MX7D_PAD_SAI2_RX_DATA__GPIO6_IO21 0x00000074
+ MX7D_PAD_ENET1_RGMII_TXC__GPIO7_IO11 0x00000014
+ >;
+ };
+
pinctrl_i2c1: i2c1grp {
fsl,pins = <
MX7D_PAD_I2C1_SDA__I2C1_SDA 0x4000007f
@@ -184,6 +239,13 @@ MX7D_PAD_I2C1_SCL__I2C1_SCL 0x4000007f
>;
};

+ pinctrl_i2c4: i2c4grp {
+ fsl,pins = <
+ MX7D_PAD_I2C4_SDA__I2C4_SDA 0x4000007f
+ MX7D_PAD_I2C4_SCL__I2C4_SCL 0x4000007f
+ >;
+ };
+
pinctrl_uart1: uart1grp {
fsl,pins = <
MX7D_PAD_UART1_TX_DATA__UART1_DCE_TX 0x79
--
2.35.1

2022-04-20 13:26:42

by Alistair Francis

[permalink] [raw]
Subject: Re: [PATCH v20 1/4] mfd: silergy,sy7636a: Add config option

On Thu, Mar 31, 2022 at 6:02 AM Guenter Roeck <[email protected]> wrote:
>
> On 3/30/22 02:41, Alistair Francis wrote:
> > Add a specific MFD_SY7636A config option.
> >
> > As part of this change we can use MFD_SY7636A as a dependency for all
> > SY7636a components and also remove the name from MFD_SIMPLE_MFD_I2C as
> > it no longer needs to be selectable.
> >
> > Signed-off-by: Alistair Francis <[email protected]>
>
> Reviewed-by: Guenter Roeck <[email protected]>

Any chance of getting this in for 5.18? It would be nice to have the
configs all sorted before the release

Alistair

>
> > ---
> > drivers/hwmon/Kconfig | 1 +
> > drivers/mfd/Kconfig | 12 +++++++++++-
> > drivers/regulator/Kconfig | 1 +
> > 3 files changed, 13 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> > index 68a8a27ab3b7..74b60d24e740 100644
> > --- a/drivers/hwmon/Kconfig
> > +++ b/drivers/hwmon/Kconfig
> > @@ -1693,6 +1693,7 @@ config SENSORS_SIS5595
> >
> > config SENSORS_SY7636A
> > tristate "Silergy SY7636A"
> > + depends on MFD_SY7636A
> > help
> > If you say yes here you get support for the thermistor readout of
> > the Silergy SY7636A PMIC.
> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 3b59456f5545..c47cb755757b 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -1095,6 +1095,16 @@ config MFD_SPMI_PMIC
> > Say M here if you want to include support for the SPMI PMIC
> > series as a module. The module will be called "qcom-spmi-pmic".
> >
> > +config MFD_SY7636A
> > + tristate "Silergy SY7636A voltage regulator"
> > + depends on I2C
> > + select MFD_SIMPLE_MFD_I2C
> > + help
> > + Enable support for Silergy SY7636A voltage regulator.
> > +
> > + To enable support for building sub-devices as modules,
> > + choose M here.
> > +
> > config MFD_RDC321X
> > tristate "RDC R-321x southbridge"
> > select MFD_CORE
> > @@ -1202,7 +1212,7 @@ config MFD_SI476X_CORE
> > module will be called si476x-core.
> >
> > config MFD_SIMPLE_MFD_I2C
> > - tristate "Simple Multi-Functional Device support (I2C)"
> > + tristate
> > depends on I2C
> > select MFD_CORE
> > select REGMAP_I2C
> > diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
> > index 5ef2306fce04..c8ce6e5eea24 100644
> > --- a/drivers/regulator/Kconfig
> > +++ b/drivers/regulator/Kconfig
> > @@ -1219,6 +1219,7 @@ config REGULATOR_STW481X_VMMC
> >
> > config REGULATOR_SY7636A
> > tristate "Silergy SY7636A voltage regulator"
> > + depends on MFD_SY7636A
> > help
> > This driver supports Silergy SY3686A voltage regulator.
> >
>

2022-04-22 18:02:12

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH v20 1/4] mfd: silergy,sy7636a: Add config option

On Wed, 20 Apr 2022, Alistair Francis wrote:

> On Thu, Mar 31, 2022 at 6:02 AM Guenter Roeck <[email protected]> wrote:
> >
> > On 3/30/22 02:41, Alistair Francis wrote:
> > > Add a specific MFD_SY7636A config option.
> > >
> > > As part of this change we can use MFD_SY7636A as a dependency for all
> > > SY7636a components and also remove the name from MFD_SIMPLE_MFD_I2C as
> > > it no longer needs to be selectable.
> > >
> > > Signed-off-by: Alistair Francis <[email protected]>
> >
> > Reviewed-by: Guenter Roeck <[email protected]>
>
> Any chance of getting this in for 5.18? It would be nice to have the
> configs all sorted before the release

Can't do anything without Mark's Ack.

--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

2022-05-24 13:51:46

by Alistair Francis

[permalink] [raw]
Subject: Re: [PATCH v20 1/4] mfd: silergy,sy7636a: Add config option

On Thu, Apr 21, 2022 at 6:07 PM Lee Jones <[email protected]> wrote:
>
> On Wed, 20 Apr 2022, Alistair Francis wrote:
>
> > On Thu, Mar 31, 2022 at 6:02 AM Guenter Roeck <[email protected]> wrote:
> > >
> > > On 3/30/22 02:41, Alistair Francis wrote:
> > > > Add a specific MFD_SY7636A config option.
> > > >
> > > > As part of this change we can use MFD_SY7636A as a dependency for all
> > > > SY7636a components and also remove the name from MFD_SIMPLE_MFD_I2C as
> > > > it no longer needs to be selectable.
> > > >
> > > > Signed-off-by: Alistair Francis <[email protected]>
> > >
> > > Reviewed-by: Guenter Roeck <[email protected]>
> >
> > Any chance of getting this in for 5.18? It would be nice to have the
> > configs all sorted before the release
>
> Can't do anything without Mark's Ack.

Can this be included in 5.19? I can re-send the series if required

Alistair

>
> --
> Lee Jones [李琼斯]
> Principal Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog

2022-05-24 13:52:12

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v20 1/4] mfd: silergy,sy7636a: Add config option

On Tue, May 24, 2022 at 09:55:37PM +1000, Alistair Francis wrote:
> On Thu, Apr 21, 2022 at 6:07 PM Lee Jones <[email protected]> wrote:
> > On Wed, 20 Apr 2022, Alistair Francis wrote:

> > > Any chance of getting this in for 5.18? It would be nice to have the
> > > configs all sorted before the release

> > Can't do anything without Mark's Ack.

> Can this be included in 5.19? I can re-send the series if required

Please don't send content free pings, please resubmit patches if you
think they've been dropped on the floor (which is probably what happened
here, but I don't have context any more for what it is). Content free
pings require people to go digging through mail archives to find out
what you're asking about, if they're even online and able to do so at
the time they look at your mail.


Attachments:
(No filename) (825.00 B)
signature.asc (499.00 B)
Download all attachments