2022-06-08 08:43:13

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH v3] ALSA: hda/realtek - Add HW8326 support

On Wed, 08 Jun 2022 09:05:27 +0200,
huangwenhui wrote:
>
> Added the support of new Huawei codec HW8326. The HW8326 is developed
> by Huawei with Realtek's IP Core, and it's compatible with ALC256.
>
> Signed-off-by: huangwenhui <[email protected]>

Thanks, applied now.


Takashi


2022-06-08 09:09:11

by Jeremy Szu

[permalink] [raw]
Subject: Re: [PATCH v3] ALSA: hda/realtek - Add HW8326 support

and better to follow the order to easy to find the codec once the list
growing next time, e.g.

@@ -651,6 +651,7 @@ static const struct hda_vendor_id hda_vendor_ids[] = {
{ 0x1095, "Silicon Image" },
{ 0x10de, "Nvidia" },
{ 0x10ec, "Realtek" },
+ { 0x19e5, "Huawei" },
{ 0x1102, "Creative" },
{ 0x1106, "VIA" },
{ 0x111d, "IDT" },

to

{ 0x14f1, "Conexant" },
{ 0x17e8, "Chrontel" },
{ 0x1854, "LG" },
+ { 0x19e5, "Huawei" },
{ 0x1aec, "Wolfson Microelectronics" },
{ 0x1af4, "QEMU" },

and so on.


On Wed, Jun 8, 2022 at 3:30 PM Takashi Iwai <[email protected]> wrote:
>
> On Wed, 08 Jun 2022 09:05:27 +0200,
> huangwenhui wrote:
> >
> > Added the support of new Huawei codec HW8326. The HW8326 is developed
> > by Huawei with Realtek's IP Core, and it's compatible with ALC256.
> >
> > Signed-off-by: huangwenhui <[email protected]>
>
> Thanks, applied now.
>
>
> Takashi



--
Sincerely,
Jeremy Su

2022-06-08 09:10:12

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH v3] ALSA: hda/realtek - Add HW8326 support

On Wed, 08 Jun 2022 09:53:32 +0200,
Jeremy Szu wrote:
>
> and better to follow the order to easy to find the codec once the list
> growing next time, e.g.
>
> @@ -651,6 +651,7 @@ static const struct hda_vendor_id hda_vendor_ids[] = {
> { 0x1095, "Silicon Image" },
> { 0x10de, "Nvidia" },
> { 0x10ec, "Realtek" },
> + { 0x19e5, "Huawei" },
> { 0x1102, "Creative" },
> { 0x1106, "VIA" },
> { 0x111d, "IDT" },
>
> to
>
> { 0x14f1, "Conexant" },
> { 0x17e8, "Chrontel" },
> { 0x1854, "LG" },
> + { 0x19e5, "Huawei" },
> { 0x1aec, "Wolfson Microelectronics" },
> { 0x1af4, "QEMU" },
>
> and so on.

Indeed. Care to send an additional patch?


thanks,

Takashi