2012-05-05 01:51:44

by Adarsh J

Subject: [PATCH 1/1] lib/mpi: Fixed erroneous check on return value of mpi_resize()

mpi_resize() returns -ENOMEM on error and 0 on success.

Signed-off-by: Adarsh J <[email protected]>
---
lib/mpi/mpicoder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/mpi/mpicoder.c b/lib/mpi/mpicoder.c
index f26b41f..9949b69 100644
--- a/lib/mpi/mpicoder.c
+++ b/lib/mpi/mpicoder.c
@@ -98,7 +98,7 @@ int mpi_fromstr(MPI val, const char *str)
nbytes = (nbits + 7) / 8;
nlimbs = (nbytes + BYTES_PER_MPI_LIMB - 1) / BYTES_PER_MPI_LIMB;
if (val->alloced < nlimbs)
- if (!mpi_resize(val, nlimbs))
+ if (mpi_resize(val, nlimbs) < 0)
return -ENOMEM;
i = BYTES_PER_MPI_LIMB - nbytes % BYTES_PER_MPI_LIMB;
i %= BYTES_PER_MPI_LIMB;
--
1.7.9.5

2012-05-05 03:30:51

by Tetsuo Handa

Subject: Re: [PATCH 1/1] lib/mpi: Fixed erroneous check on return value of mpi_resize()

Adarsh J wrote:
> mpi_resize() returns -ENOMEM on error and 0 on success.

Good catch.

But it seems to me that mpi_fromstr() has no in-tree users.
Also, mpi_fromstr() in RHEL 5.8/6.2 has no users.
We forgot to exclude when adding MPI support?

>
> Signed-off-by: Adarsh J <[email protected]>
> ---
> lib/mpi/mpicoder.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/mpi/mpicoder.c b/lib/mpi/mpicoder.c
> index f26b41f..9949b69 100644
> --- a/lib/mpi/mpicoder.c
> +++ b/lib/mpi/mpicoder.c
> @@ -98,7 +98,7 @@ int mpi_fromstr(MPI val, const char *str)
> nbytes = (nbits + 7) / 8;
> nlimbs = (nbytes + BYTES_PER_MPI_LIMB - 1) / BYTES_PER_MPI_LIMB;
> if (val->alloced < nlimbs)
> - if (!mpi_resize(val, nlimbs))
> + if (mpi_resize(val, nlimbs) < 0)
> return -ENOMEM;
> i = BYTES_PER_MPI_LIMB - nbytes % BYTES_PER_MPI_LIMB;
> i %= BYTES_PER_MPI_LIMB;
> --
> 1.7.9.5

2012-05-07 01:27:41

by James Morris

Subject: Re: [PATCH 1/1] lib/mpi: Fixed erroneous check on return value of mpi_resize()

On Sat, 5 May 2012, Tetsuo Handa wrote:

> Adarsh J wrote:
> > mpi_resize() returns -ENOMEM on error and 0 on success.
>
> Good catch.
>
> But it seems to me that mpi_fromstr() has no in-tree users.
> Also, mpi_fromstr() in RHEL 5.8/6.2 has no users.
> We forgot to exclude when adding MPI support?

If that's the case, then it should be removed.

(Removed root@ from cc:)

>
> >
> > Signed-off-by: Adarsh J <[email protected]>
> > ---
> > lib/mpi/mpicoder.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/mpi/mpicoder.c b/lib/mpi/mpicoder.c
> > index f26b41f..9949b69 100644
> > --- a/lib/mpi/mpicoder.c
> > +++ b/lib/mpi/mpicoder.c
> > @@ -98,7 +98,7 @@ int mpi_fromstr(MPI val, const char *str)
> > nbytes = (nbits + 7) / 8;
> > nlimbs = (nbytes + BYTES_PER_MPI_LIMB - 1) / BYTES_PER_MPI_LIMB;
> > if (val->alloced < nlimbs)
> > - if (!mpi_resize(val, nlimbs))
> > + if (mpi_resize(val, nlimbs) < 0)
> > return -ENOMEM;
> > i = BYTES_PER_MPI_LIMB - nbytes % BYTES_PER_MPI_LIMB;
> > i %= BYTES_PER_MPI_LIMB;
> > --
> > 1.7.9.5
>

--
James Morris
<[email protected]>

2012-05-07 13:20:38

by Kasatkin, Dmitry

Subject: Re: [PATCH 1/1] lib/mpi: Fixed erroneous check on return value of mpi_resize()

On Sat, May 5, 2012 at 4:51 AM, Adarsh J <[email protected]> wrote:
> mpi_resize() returns -ENOMEM on error and 0 on success.
>
> Signed-off-by: Adarsh J <[email protected]>

Acked-by: Dmitry Kasatkin <[email protected]>

Thanks.

> ---
>  lib/mpi/mpicoder.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/mpi/mpicoder.c b/lib/mpi/mpicoder.c
> index f26b41f..9949b69 100644
> --- a/lib/mpi/mpicoder.c
> +++ b/lib/mpi/mpicoder.c
> @@ -98,7 +98,7 @@ int mpi_fromstr(MPI val, const char *str)
>        nbytes = (nbits + 7) / 8;
>        nlimbs = (nbytes + BYTES_PER_MPI_LIMB - 1) / BYTES_PER_MPI_LIMB;
>        if (val->alloced < nlimbs)
> -               if (!mpi_resize(val, nlimbs))
> +               if (mpi_resize(val, nlimbs) < 0)
>                        return -ENOMEM;
>        i = BYTES_PER_MPI_LIMB - nbytes % BYTES_PER_MPI_LIMB;
>        i %= BYTES_PER_MPI_LIMB;
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
> the body of a message to [email protected]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html