2021-11-17 07:22:18

by ChiYuan Huang

[permalink] [raw]
Subject: [PATCH] dt-bindings: leds: Replace moonlight with indicator in mt6360 example

From: ChiYuan Huang <[email protected]>

Replace moonlight with indicator in mt6360 example to prevent the below
build error:

Error: Documentation/devicetree/bindings/leds/leds-mt6360.example.dts:114.24-25
syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:385:
Documentation/devicetree/bindings/leds/leds-mt6360.example.dt.yaml]
Error 1

Link: https://lore.kernel.org/lkml/CAL_JsqJRMVE163LaHTbtFARc4f_qg33bfQx+sD3ukce_xQF+gA@mail.gmail.com/
Signed-off-by: ChiYuan Huang <[email protected]>
---
Hi, Gene:

I saw you have removed LED_FUNCTION_MOONLIGHT in v14.
But you may forget to remove it from the binding example.

Please help to review this change.
---
Documentation/devicetree/bindings/leds/leds-mt6360.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/leds/leds-mt6360.yaml b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
index 2353155..b2fe6eb 100644
--- a/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
@@ -133,7 +133,7 @@ examples:
};
led@3 {
reg = <3>;
- function = LED_FUNCTION_MOONLIGHT;
+ function = LED_FUNCTION_INDICATOR;
color = <LED_COLOR_ID_WHITE>;
led-max-microamp = <150000>;
};
--
2.7.4



2021-11-17 10:53:07

by Gene Chen

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: leds: Replace moonlight with indicator in mt6360 example

cy_huang <[email protected]> 於 2021年11月17日 週三 下午3:22寫道：
>
> From: ChiYuan Huang <[email protected]>
>
> Replace moonlight with indicator in mt6360 example to prevent the below
> build error:
>
> Error: Documentation/devicetree/bindings/leds/leds-mt6360.example.dts:114.24-25
> syntax error
> FATAL ERROR: Unable to parse input tree
> make[1]: *** [scripts/Makefile.lib:385:
> Documentation/devicetree/bindings/leds/leds-mt6360.example.dt.yaml]
> Error 1
>
> Link: https://lore.kernel.org/lkml/CAL_JsqJRMVE163LaHTbtFARc4f_qg33bfQx+sD3ukce_xQF+gA@mail.gmail.com/
> Signed-off-by: ChiYuan Huang <[email protected]>
> ---
> Hi, Gene:
>
> I saw you have removed LED_FUNCTION_MOONLIGHT in v14.
> But you may forget to remove it from the binding example.
>
> Please help to review this change.
> ---
> Documentation/devicetree/bindings/leds/leds-mt6360.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-mt6360.yaml b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
> index 2353155..b2fe6eb 100644
> --- a/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
> @@ -133,7 +133,7 @@ examples:
> };
> led@3 {
> reg = <3>;
> - function = LED_FUNCTION_MOONLIGHT;
> + function = LED_FUNCTION_INDICATOR;
> color = <LED_COLOR_ID_WHITE>;
> led-max-microamp = <150000>;
> };
> --
> 2.7.4
>

Reviewed-by: Gene Chen <[email protected]>
Thanks

2021-11-18 14:38:44

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: leds: Replace moonlight with indicator in mt6360 example

On Wed, Nov 17, 2021 at 1:22 AM cy_huang <[email protected]> wrote:
>
> From: ChiYuan Huang <[email protected]>
>
> Replace moonlight with indicator in mt6360 example to prevent the below
> build error:
>
> Error: Documentation/devicetree/bindings/leds/leds-mt6360.example.dts:114.24-25
> syntax error
> FATAL ERROR: Unable to parse input tree
> make[1]: *** [scripts/Makefile.lib:385:
> Documentation/devicetree/bindings/leds/leds-mt6360.example.dt.yaml]
> Error 1
>
> Link: https://lore.kernel.org/lkml/CAL_JsqJRMVE163LaHTbtFARc4f_qg33bfQx+sD3ukce_xQF+gA@mail.gmail.com/
> Signed-off-by: ChiYuan Huang <[email protected]>
> ---
> Hi, Gene:
>
> I saw you have removed LED_FUNCTION_MOONLIGHT in v14.
> But you may forget to remove it from the binding example.
>
> Please help to review this change.
> ---
> Documentation/devicetree/bindings/leds/leds-mt6360.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Rob Herring <[email protected]>

2021-11-18 19:47:12

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: leds: Replace moonlight with indicator in mt6360 example

Hi!

> Replace moonlight with indicator in mt6360 example to prevent the below
> build error:
>
> Error: Documentation/devicetree/bindings/leds/leds-mt6360.example.dts:114.24-25
> syntax error
> FATAL ERROR: Unable to parse input tree
> make[1]: *** [scripts/Makefile.lib:385:
> Documentation/devicetree/bindings/leds/leds-mt6360.example.dt.yaml]
> Error 1

Thanks, applied, hopefully it makes the checker happy.

Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek

Attachments:
(No filename) (486.00 B)
 signature.asc (195.00 B)
 Download all attachments