2017-11-01 20:41:06

by Rob Herring

[permalink] [raw]
Subject: Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

On Tue, Oct 31, 2017 at 9:17 PM, Viresh Kumar <[email protected]> wrote:
> On 31 October 2017 at 16:02, Rob Herring <[email protected]> wrote:
>> Why not a new property for magic values? opp-magic? Don't we want to
>> know when we have magic values?
>
> I have kept a separate property since beginning (domain-performance-state)
> and moved to using these magic values in the existing field because of the
> suggestion Kevin gave earlier.
>
> https://marc.info/?l=linux-kernel&m=149306082218001&w=2
>
> I am not sure what to do now :)

Okay, I guess reusing the properties is fine.

>> Wouldn't magic values in opp-hz get propagated to user space?
>
> The OPP core puts them in debugfs just to know how the OPPs are
> set. Otherwise, I am not sure that the power domain core/drivers would
> be exposing that to user space.

I was thinking thru the cpufreq interface, but I guess this is not for cpus.

Rob

From 1582828337716868258@xxx Wed Nov 01 02:18:52 +0000 2017
X-GM-THRID: 1582777408429643294
X-Gmail-Labels: Inbox,Category Forums