2017-11-08 13:40:10

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH 02/31] nds32: Kernel booting and initialization

On Tue, Nov 7, 2017 at 11:54 PM, Greentime Hu <[email protected]> wrote:
> From: Greentime Hu <[email protected]>
>

Commit message needed.

> Signed-off-by: Vincent Chen <[email protected]>
> Signed-off-by: Greentime Hu <[email protected]>
> ---

> + /* it could update max_pfn */
> + if (max_pfn - ram_start_pfn <= MAXMEM_PFN)
> + max_low_pfn = max_pfn;
> + else {
> + max_low_pfn = MAXMEM_PFN + ram_start_pfn;
> +#ifndef CONFIG_HIGHMEM

Use IS_ENABLED here and other ifdef's if possible.

> + max_pfn = MAXMEM_PFN + ram_start_pfn;
> +#endif
> + }


> +static int __init nds32_device_probe(void)
> +{
> + return of_platform_populate(NULL, NULL, NULL, NULL);
> +}
> +
> +device_initcall(nds32_device_probe);

You can drop this. The core code will call of_platform_populate for you.

From 1583483485147725708@xxx Wed Nov 08 07:52:10 +0000 2017
X-GM-THRID: 1583483485147725708
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread