On Wed, Feb 17, 2021 at 03:30:38PM +0000, Rui Salvaterra wrote:
> Hardware buffer management has never worked on the Turris Omnia, as the
> required MBus window hadn't been reserved. Fix thusly.
Hi Rui
I don't know all the details for the MBus Windows...
Can this be set once in armada-385.dtsi ?
Did you check the other dts files. Do any others have the same
problem?
Andrew
On Wed, 17 Feb 2021 17:22:17 +0100
Andrew Lunn <[email protected]> wrote:
> On Wed, Feb 17, 2021 at 03:30:38PM +0000, Rui Salvaterra wrote:
> > Hardware buffer management has never worked on the Turris Omnia, as the
> > required MBus window hadn't been reserved. Fix thusly.
>
> Hi Rui
>
> I don't know all the details for the MBus Windows...
>
> Can this be set once in armada-385.dtsi ?
>
> Did you check the other dts files. Do any others have the same
> problem?
>
> Andrew
armada-38x.dtsi defines only
ranges = <0 MBUS_ID(0xf0, 0x01) 0 0x100000>;
for internal-regs.
It probably depends on how the mbus driver works.
If the mbus driver maps every window defined in ranges, regardless
whether they are used, then we do not want to put all windows in .dtsi
file.
Marek
Hi, Andrew,
On Wed, 17 Feb 2021 at 16:22, Andrew Lunn <[email protected]> wrote:
>
> Hi Rui
>
> I don't know all the details for the MBus Windows...
Neither do I, I just followed the examples in other device trees
(namely armada-385-linksys.dtsi). I wanted to get hardware buffer
management working on my Omnia, in OpenWrt, so I started digging. :)
> Can this be set once in armada-385.dtsi ?
If all SoCs support it, I don't see why not. However, I have to defer
to someone with experience on these systems.
> Did you check the other dts files. Do any others have the same
> problem?
I did a cursory grep, yes. I see a lot of .dts files with the correct
declaration, so probably aren't that many missing (if any at all,
anymore).
Thanks,
Rui