2018-07-31 14:24:08

by Gustavo A. R. Silva

Subject: [PATCH] net/mlx5e: Fix uninitialized variable

There is a potential execution path in which variable *err* is returned
without being properly initialized previously.

Fix this by initializing variable *err* to 0.

Addresses-Coverity-ID: 1472116 ("Uninitialized scalar variable")
Fixes: 0ec13877ce95 ("net/mlx5e: Gather all XDP pre-requisite checks in a single function")
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
index fde3502..de2827a 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
@@ -4215,7 +4215,7 @@ static int mlx5e_xdp_set(struct net_device *netdev, struct bpf_prog *prog)
struct mlx5e_priv *priv = netdev_priv(netdev);
struct bpf_prog *old_prog;
bool reset, was_opened;
- int err;
+ int err = 0;
int i;

mutex_lock(&priv->state_lock);
--
2.7.4

2018-07-31 14:52:30

by Tariq Toukan

Subject: Re: [PATCH] net/mlx5e: Fix uninitialized variable

On 31/07/2018 5:21 PM, Gustavo A. R. Silva wrote:
> There is a potential execution path in which variable *err* is returned
> without being properly initialized previously.
>
> Fix this by initializing variable *err* to 0.
>
> Addresses-Coverity-ID: 1472116 ("Uninitialized scalar variable")
> Fixes: 0ec13877ce95 ("net/mlx5e: Gather all XDP pre-requisite checks in a single function")
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> index fde3502..de2827a 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> @@ -4215,7 +4215,7 @@ static int mlx5e_xdp_set(struct net_device *netdev, struct bpf_prog *prog)
> struct mlx5e_priv *priv = netdev_priv(netdev);
> struct bpf_prog *old_prog;
> bool reset, was_opened;
> - int err;
> + int err = 0;
> int i;
>
> mutex_lock(&priv->state_lock);
>

Reviewed-by: Tariq Toukan <[email protected]>

Thanks.

2018-07-31 21:50:04

by Saeed Mahameed

Subject: Re: [PATCH] net/mlx5e: Fix uninitialized variable

On Tue, Jul 31, 2018 at 7:21 AM, Gustavo A. R. Silva
<[email protected]> wrote:
> There is a potential execution path in which variable *err* is returned
> without being properly initialized previously.
>
> Fix this by initializing variable *err* to 0.
>
> Addresses-Coverity-ID: 1472116 ("Uninitialized scalar variable")
> Fixes: 0ec13877ce95 ("net/mlx5e: Gather all XDP pre-requisite checks in a single function")
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Acked-by: Saeed Mahameed <[email protected]>

2018-08-01 16:39:59

by David Miller

Subject: Re: [PATCH] net/mlx5e: Fix uninitialized variable

From: "Gustavo A. R. Silva" <[email protected]>
Date: Tue, 31 Jul 2018 09:21:57 -0500

> There is a potential execution path in which variable *err* is returned
> without being properly initialized previously.
>
> Fix this by initializing variable *err* to 0.
>
> Addresses-Coverity-ID: 1472116 ("Uninitialized scalar variable")
> Fixes: 0ec13877ce95 ("net/mlx5e: Gather all XDP pre-requisite checks in a single function")
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Applied to net-next.

2018-08-01 18:17:13

by Gustavo A. R. Silva

Subject: Re: [PATCH] net/mlx5e: Fix uninitialized variable

On 08/01/2018 11:38 AM, David Miller wrote:
> From: "Gustavo A. R. Silva" <[email protected]>
> Date: Tue, 31 Jul 2018 09:21:57 -0500
>
>> There is a potential execution path in which variable *err* is returned
>> without being properly initialized previously.
>>
>> Fix this by initializing variable *err* to 0.
>>
>> Addresses-Coverity-ID: 1472116 ("Uninitialized scalar variable")
>> Fixes: 0ec13877ce95 ("net/mlx5e: Gather all XDP pre-requisite checks in a single function")
>> Signed-off-by: Gustavo A. R. Silva <[email protected]>
>
> Applied to net-next.
>

David,

Sorry I failed to tag this patch for net-next. I got a bit confused, once based on the logs,
the usual committer for this driver is Saeed Mahameed; not you. So, I wasn't quite sure about
how to proceed.

Thanks
--
Gustavo