2023-09-12 06:00:59

by Namhyung Kim

[permalink] [raw]
Subject: Re: [PATCH v1 3/5] perf expr: Make YYDEBUG dependent on doing a debug build

On Mon, Sep 11, 2023 at 10:06 AM Ian Rogers <[email protected]> wrote:
>
> YYDEBUG enables line numbers and other error helpers in the generated
> expr-bison.c. These shouldn't be generated when debugging
> isn't enabled.
>
> Signed-off-by: Ian Rogers <[email protected]>

Acked-by: Namhyung Kim <[email protected]>

Thanks,
Namhyung


> ---
> tools/perf/util/expr.y | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/util/expr.y b/tools/perf/util/expr.y
> index 6c93b358cc2d..e364790babb5 100644
> --- a/tools/perf/util/expr.y
> +++ b/tools/perf/util/expr.y
> @@ -1,6 +1,8 @@
> /* Simple expression parser */
> %{
> +#ifndef NDEBUG
> #define YYDEBUG 1
> +#endif
> #include <assert.h>
> #include <math.h>
> #include <stdlib.h>
> --
> 2.42.0.283.g2d96d420d3-goog
>