2023-06-01 03:04:12

by Ian Rogers

Subject: [PATCH v1 1/2] perf pmu: Only warn about unsupported configs once

Avoid scanning format list for each event parsed.

Signed-off-by: Ian Rogers <[email protected]>
---
tools/perf/util/pmu.c | 5 +++++
tools/perf/util/pmu.h | 5 +++++
2 files changed, 10 insertions(+)

diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
index 0520aa9fe991..204ce3f02e63 100644
--- a/tools/perf/util/pmu.c
+++ b/tools/perf/util/pmu.c
@@ -934,6 +934,11 @@ void perf_pmu__warn_invalid_formats(struct perf_pmu *pmu)
{
struct perf_pmu_format *format;

+ if (pmu->formats_checked)
+ return;
+
+ pmu->formats_checked = true;
+
/* fake pmu doesn't have format list */
if (pmu == &perf_pmu__fake)
return;
diff --git a/tools/perf/util/pmu.h b/tools/perf/util/pmu.h
index 287f593b15c7..7a1535dc1f12 100644
--- a/tools/perf/util/pmu.h
+++ b/tools/perf/util/pmu.h
@@ -76,6 +76,11 @@ struct perf_pmu {
* specific code.
*/
bool auxtrace;
+ /**
+ * @formats_checked: Only check PMU's formats are valid for
+ * perf_event_attr once.
+ */
+ bool formats_checked;
/**
* @max_precise: Number of levels of :ppp precision supported by the
* PMU, read from
--
2.41.0.rc0.172.g3f132b7071-goog

2023-06-01 20:07:19

by Namhyung Kim

Subject: Re: [PATCH v1 1/2] perf pmu: Only warn about unsupported configs once

On Wed, May 31, 2023 at 7:36 PM Ian Rogers <[email protected]> wrote:
>
> Avoid scanning format list for each event parsed.

Maybe it's better to change the subject that it's about format..
Other than that,

Acked-by: Namhyung Kim <[email protected]>

Thanks,
Namhyung


>
> Signed-off-by: Ian Rogers <[email protected]>
> ---
> tools/perf/util/pmu.c | 5 +++++
> tools/perf/util/pmu.h | 5 +++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> index 0520aa9fe991..204ce3f02e63 100644
> --- a/tools/perf/util/pmu.c
> +++ b/tools/perf/util/pmu.c
> @@ -934,6 +934,11 @@ void perf_pmu__warn_invalid_formats(struct perf_pmu *pmu)
> {
> struct perf_pmu_format *format;
>
> + if (pmu->formats_checked)
> + return;
> +
> + pmu->formats_checked = true;
> +
> /* fake pmu doesn't have format list */
> if (pmu == &perf_pmu__fake)
> return;
> diff --git a/tools/perf/util/pmu.h b/tools/perf/util/pmu.h
> index 287f593b15c7..7a1535dc1f12 100644
> --- a/tools/perf/util/pmu.h
> +++ b/tools/perf/util/pmu.h
> @@ -76,6 +76,11 @@ struct perf_pmu {
> * specific code.
> */
> bool auxtrace;
> + /**
> + * @formats_checked: Only check PMU's formats are valid for
> + * perf_event_attr once.
> + */
> + bool formats_checked;
> /**
> * @max_precise: Number of levels of :ppp precision supported by the
> * PMU, read from
> --
> 2.41.0.rc0.172.g3f132b7071-goog
>

2023-06-01 20:25:24

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH v1 1/2] perf pmu: Only warn about unsupported configs once

Em Thu, Jun 01, 2023 at 01:04:30PM -0700, Namhyung Kim escreveu:
> On Wed, May 31, 2023 at 7:36 PM Ian Rogers <[email protected]> wrote:
> >
> > Avoid scanning format list for each event parsed.
>
> Maybe it's better to change the subject that it's about format..
> Other than that,

Ok, I can fix that, applying.

> Acked-by: Namhyung Kim <[email protected]>
>
> Thanks,
> Namhyung
>
>
> >
> > Signed-off-by: Ian Rogers <[email protected]>
> > ---
> > tools/perf/util/pmu.c | 5 +++++
> > tools/perf/util/pmu.h | 5 +++++
> > 2 files changed, 10 insertions(+)
> >
> > diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> > index 0520aa9fe991..204ce3f02e63 100644
> > --- a/tools/perf/util/pmu.c
> > +++ b/tools/perf/util/pmu.c
> > @@ -934,6 +934,11 @@ void perf_pmu__warn_invalid_formats(struct perf_pmu *pmu)
> > {
> > struct perf_pmu_format *format;
> >
> > + if (pmu->formats_checked)
> > + return;
> > +
> > + pmu->formats_checked = true;
> > +
> > /* fake pmu doesn't have format list */
> > if (pmu == &perf_pmu__fake)
> > return;
> > diff --git a/tools/perf/util/pmu.h b/tools/perf/util/pmu.h
> > index 287f593b15c7..7a1535dc1f12 100644
> > --- a/tools/perf/util/pmu.h
> > +++ b/tools/perf/util/pmu.h
> > @@ -76,6 +76,11 @@ struct perf_pmu {
> > * specific code.
> > */
> > bool auxtrace;
> > + /**
> > + * @formats_checked: Only check PMU's formats are valid for
> > + * perf_event_attr once.
> > + */
> > + bool formats_checked;
> > /**
> > * @max_precise: Number of levels of :ppp precision supported by the
> > * PMU, read from
> > --
> > 2.41.0.rc0.172.g3f132b7071-goog
> >

--

- Arnaldo