2023-06-23 06:19:51

by Ian Rogers

Subject: [PATCH v3 0/3] Remove symbol_name_rb_node

Use a sorted array of symbol pointers to avoid the potentially
unnecessary 3 pointers (rb_node) for the name sorted symbols. Saves
been 24 and 16 bytes per symbol.

v3. Move sort by name dso lock into its own patch.
v2. map__find_symbol_by_name_idx so that map__find_symbol_by_name
doesn't need an optional parameter. Separate out
symbol_conf.sort_by_name removal.

Ian Rogers (3):
perf dso: Sort symbols under lock
perf symbol: Remove symbol_name_rb_node
perf symbol_conf: Remove now unused sort_by_name

tools/perf/builtin-kallsyms.c | 1 -
tools/perf/builtin-lock.c | 2 -
tools/perf/builtin-report.c | 1 -
tools/perf/tests/builtin-test.c | 1 -
tools/perf/util/dso.c | 7 +-
tools/perf/util/dso.h | 3 +-
tools/perf/util/map.c | 14 +++-
tools/perf/util/map.h | 12 +--
tools/perf/util/probe-event.c | 16 ++--
tools/perf/util/symbol.c | 131 ++++++++++++++++---------------
tools/perf/util/symbol.h | 12 +--
tools/perf/util/symbol_conf.h | 1 -
tools/perf/util/symbol_fprintf.c | 10 +--
13 files changed, 106 insertions(+), 105 deletions(-)

--
2.41.0.162.gfafddb0af9-goog

2023-06-24 05:01:08

by Namhyung Kim

Subject: Re: [PATCH v3 0/3] Remove symbol_name_rb_node

On Thu, Jun 22, 2023 at 10:45 PM Ian Rogers <[email protected]> wrote:
>
> Use a sorted array of symbol pointers to avoid the potentially
> unnecessary 3 pointers (rb_node) for the name sorted symbols. Saves
> been 24 and 16 bytes per symbol.
>
> v3. Move sort by name dso lock into its own patch.
> v2. map__find_symbol_by_name_idx so that map__find_symbol_by_name
> doesn't need an optional parameter. Separate out
> symbol_conf.sort_by_name removal.
>
> Ian Rogers (3):
> perf dso: Sort symbols under lock
> perf symbol: Remove symbol_name_rb_node
> perf symbol_conf: Remove now unused sort_by_name

Acked-by: Namhyung Kim <[email protected]>

Thanks,
Namhyung


>
> tools/perf/builtin-kallsyms.c | 1 -
> tools/perf/builtin-lock.c | 2 -
> tools/perf/builtin-report.c | 1 -
> tools/perf/tests/builtin-test.c | 1 -
> tools/perf/util/dso.c | 7 +-
> tools/perf/util/dso.h | 3 +-
> tools/perf/util/map.c | 14 +++-
> tools/perf/util/map.h | 12 +--
> tools/perf/util/probe-event.c | 16 ++--
> tools/perf/util/symbol.c | 131 ++++++++++++++++---------------
> tools/perf/util/symbol.h | 12 +--
> tools/perf/util/symbol_conf.h | 1 -
> tools/perf/util/symbol_fprintf.c | 10 +--
> 13 files changed, 106 insertions(+), 105 deletions(-)
>
> --
> 2.41.0.162.gfafddb0af9-goog
>

2023-06-25 00:26:31

by Namhyung Kim

Subject: Re: [PATCH v3 0/3] Remove symbol_name_rb_node

On Fri, Jun 23, 2023 at 9:42 PM Namhyung Kim <[email protected]> wrote:
>
> On Thu, Jun 22, 2023 at 10:45 PM Ian Rogers <[email protected]> wrote:
> >
> > Use a sorted array of symbol pointers to avoid the potentially
> > unnecessary 3 pointers (rb_node) for the name sorted symbols. Saves
> > been 24 and 16 bytes per symbol.
> >
> > v3. Move sort by name dso lock into its own patch.
> > v2. map__find_symbol_by_name_idx so that map__find_symbol_by_name
> > doesn't need an optional parameter. Separate out
> > symbol_conf.sort_by_name removal.
> >
> > Ian Rogers (3):
> > perf dso: Sort symbols under lock
> > perf symbol: Remove symbol_name_rb_node
> > perf symbol_conf: Remove now unused sort_by_name
>
> Acked-by: Namhyung Kim <[email protected]>

Applied to perf-tools-next, thanks!