2012-02-04 15:25:40

by Hitoshi Mitake

[permalink] [raw]
Subject: Re: [PATCH] NVMe: Fix compilation on architecturs without readq/writeq

On Tue, Jan 31, 2012 at 12:05, Linus Torvalds
<[email protected]> wrote:
> On Mon, Jan 30, 2012 at 7:03 PM, Linus Torvalds
> <[email protected]> wrote:
>> ?val |= readl(addr+4) << 32;
>
> Oops. That needs a cast to u64 before the shift, of course.
>
> Take all code I write in emails with a pinch of salt - think of it
> more as pseudo-code than something that necessarily would work as-is.
>
> ? ? ? ? ? ? ? ? ?Linus

I'll take care, thanks :)


--
Hitoshi Mitake
[email protected]