2023-03-09 03:18:23

by Jiapeng Chong

Subject: [PATCH] gpio: loongson: Remove unnecessary .owner

Remove .owner field if calls are used which set it automatically.

./drivers/gpio/gpio-loongson-64bit.c:225:3-8: No need to set .owner here. The core will do it.

Reported-by: Abaci Robot <[email protected]>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4450
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/gpio/gpio-loongson-64bit.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpio/gpio-loongson-64bit.c b/drivers/gpio/gpio-loongson-64bit.c
index 20a68e5e66c1..06213bbfabdd 100644
--- a/drivers/gpio/gpio-loongson-64bit.c
+++ b/drivers/gpio/gpio-loongson-64bit.c
@@ -222,7 +222,6 @@ MODULE_DEVICE_TABLE(acpi, loongson_gpio_acpi_match);
static struct platform_driver loongson_gpio_driver = {
.driver = {
.name = "loongson-gpio",
- .owner = THIS_MODULE,
.of_match_table = loongson_gpio_of_match,
.acpi_match_table = loongson_gpio_acpi_match,
},
--
2.20.1.7.g153144c

2023-03-10 15:41:48

by Bartosz Golaszewski

Subject: Re: [PATCH] gpio: loongson: Remove unnecessary .owner

On Thu, Mar 9, 2023 at 4:18 AM Jiapeng Chong
<[email protected]> wrote:
>
> Remove .owner field if calls are used which set it automatically.
>
> ./drivers/gpio/gpio-loongson-64bit.c:225:3-8: No need to set .owner here. The core will do it.
>
> Reported-by: Abaci Robot <[email protected]>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4450
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> drivers/gpio/gpio-loongson-64bit.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-loongson-64bit.c b/drivers/gpio/gpio-loongson-64bit.c
> index 20a68e5e66c1..06213bbfabdd 100644
> --- a/drivers/gpio/gpio-loongson-64bit.c
> +++ b/drivers/gpio/gpio-loongson-64bit.c
> @@ -222,7 +222,6 @@ MODULE_DEVICE_TABLE(acpi, loongson_gpio_acpi_match);
> static struct platform_driver loongson_gpio_driver = {
> .driver = {
> .name = "loongson-gpio",
> - .owner = THIS_MODULE,
> .of_match_table = loongson_gpio_of_match,
> .acpi_match_table = loongson_gpio_acpi_match,
> },
> --
> 2.20.1.7.g153144c
>

Applied, thanks!

Bart