2023-04-19 12:09:50

by Loic Poulain

[permalink] [raw]
Subject: Re: [net-next v2] wwan: core: add print for wwan port attach/disconnect

On Mon, 17 Apr 2023 at 11:47, Slark Xiao <[email protected]> wrote:
>
> Refer to USB serial device or net device, there is a notice to
> let end user know the status of device, like attached or
> disconnected. Add attach/disconnect print for wwan device as
> well.
>
> Signed-off-by: Slark Xiao <[email protected]>

Reviewed-by: Loic Poulain <[email protected]>

> ---
>
> v2: Use dev_name() instead of kobj item and make print neat.
> ---
> drivers/net/wwan/wwan_core.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c
> index 2e1c01cf00a9..aa54fa6d5f90 100644
> --- a/drivers/net/wwan/wwan_core.c
> +++ b/drivers/net/wwan/wwan_core.c
> @@ -492,6 +492,7 @@ struct wwan_port *wwan_create_port(struct device *parent,
> if (err)
> goto error_put_device;
>
> + dev_info(&wwandev->dev, "port %s attached\n", dev_name(&port->dev));
> return port;
>
> error_put_device:
> @@ -517,6 +518,8 @@ void wwan_remove_port(struct wwan_port *port)
>
> skb_queue_purge(&port->rxq);
> dev_set_drvdata(&port->dev, NULL);
> +
> + dev_info(&wwandev->dev, "port %s disconnected\n", dev_name(&port->dev));
> device_unregister(&port->dev);
>
> /* Release related wwan device */
> --
> 2.34.1
>