2021-03-05 00:58:24

by Cong Wang

[permalink] [raw]
Subject: Re: [PATCH] net: sched: avoid duplicates in classes dump

On Thu, Mar 4, 2021 at 6:44 AM Maximilian Heyne <[email protected]> wrote:
>
> This is a follow up of commit ea3274695353 ("net: sched: avoid
> duplicates in qdisc dump") which has fixed the issue only for the qdisc
> dump.
>
> The duplicate printing also occurs when dumping the classes via
> tc class show dev eth0
>
> Fixes: 59cc1f61f09c ("net: sched: convert qdisc linked list to hashtable")
> Signed-off-by: Maximilian Heyne <[email protected]>

Seems reasonable. If you can show the difference of tc class dump
before and after this patch in your changelog, it would be helpful to
understand the bug here.

Thanks.