2019-12-27 11:52:48

by chenzhou

Subject: [PATCH next] drm/gma500: remove set but not used variables 'hist_reg'

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/gma500/psb_irq.c: In function psb_irq_turn_off_dpst:
drivers/gpu/drm/gma500/psb_irq.c:473:6:
warning: variable hist_reg set but not used [-Wunused-but-set-variable]

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Chen Zhou <[email protected]>
---
drivers/gpu/drm/gma500/psb_irq.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/gma500/psb_irq.c b/drivers/gpu/drm/gma500/psb_irq.c
index 40a37e4..91f9001 100644
--- a/drivers/gpu/drm/gma500/psb_irq.c
+++ b/drivers/gpu/drm/gma500/psb_irq.c
@@ -470,12 +470,11 @@ void psb_irq_turn_off_dpst(struct drm_device *dev)
{
struct drm_psb_private *dev_priv =
(struct drm_psb_private *) dev->dev_private;
- u32 hist_reg;
u32 pwm_reg;

if (gma_power_begin(dev, false)) {
PSB_WVDC32(0x00000000, HISTOGRAM_INT_CONTROL);
- hist_reg = PSB_RVDC32(HISTOGRAM_INT_CONTROL);
+ PSB_RVDC32(HISTOGRAM_INT_CONTROL);

psb_disable_pipestat(dev_priv, 0, PIPE_DPST_EVENT_ENABLE);

--
2.7.4

2020-01-08 09:14:41

by Patrik Jakobsson

Subject: Re: [PATCH next] drm/gma500: remove set but not used variables 'hist_reg'

On Fri, Dec 27, 2019 at 12:52 PM Chen Zhou <[email protected]> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/gma500/psb_irq.c: In function psb_irq_turn_off_dpst:
> drivers/gpu/drm/gma500/psb_irq.c:473:6:
> warning: variable hist_reg set but not used [-Wunused-but-set-variable]
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Chen Zhou <[email protected]>

Applied to drm-misc-next

Thanks
Patrik

> ---
> drivers/gpu/drm/gma500/psb_irq.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/psb_irq.c b/drivers/gpu/drm/gma500/psb_irq.c
> index 40a37e4..91f9001 100644
> --- a/drivers/gpu/drm/gma500/psb_irq.c
> +++ b/drivers/gpu/drm/gma500/psb_irq.c
> @@ -470,12 +470,11 @@ void psb_irq_turn_off_dpst(struct drm_device *dev)
> {
> struct drm_psb_private *dev_priv =
> (struct drm_psb_private *) dev->dev_private;
> - u32 hist_reg;
> u32 pwm_reg;
>
> if (gma_power_begin(dev, false)) {
> PSB_WVDC32(0x00000000, HISTOGRAM_INT_CONTROL);
> - hist_reg = PSB_RVDC32(HISTOGRAM_INT_CONTROL);
> + PSB_RVDC32(HISTOGRAM_INT_CONTROL);
>
> psb_disable_pipestat(dev_priv, 0, PIPE_DPST_EVENT_ENABLE);
>
> --
> 2.7.4
>