2023-03-19 14:24:16

by Tom Rix

Subject: [PATCH] drm/gma500: remove unused gma_pipe_event function

clang with W=1 reports
drivers/gpu/drm/gma500/psb_irq.c:35:19: error: unused function
'gma_pipe_event' [-Werror,-Wunused-function]
static inline u32 gma_pipe_event(int pipe)
^
This function is not used, so remove it.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/gpu/drm/gma500/psb_irq.c | 11 -----------
1 file changed, 11 deletions(-)

diff --git a/drivers/gpu/drm/gma500/psb_irq.c b/drivers/gpu/drm/gma500/psb_irq.c
index d421031462df..343c51250207 100644
--- a/drivers/gpu/drm/gma500/psb_irq.c
+++ b/drivers/gpu/drm/gma500/psb_irq.c
@@ -32,17 +32,6 @@ static inline u32 gma_pipestat(int pipe)
BUG();
}

-static inline u32 gma_pipe_event(int pipe)
-{
- if (pipe == 0)
- return _PSB_PIPEA_EVENT_FLAG;
- if (pipe == 1)
- return _MDFLD_PIPEB_EVENT_FLAG;
- if (pipe == 2)
- return _MDFLD_PIPEC_EVENT_FLAG;
- BUG();
-}
-
static inline u32 gma_pipeconf(int pipe)
{
if (pipe == 0)
--
2.27.0

2023-03-21 08:21:13

by Patrik Jakobsson

Subject: Re: [PATCH] drm/gma500: remove unused gma_pipe_event function

On Sun, Mar 19, 2023 at 3:23 PM Tom Rix <[email protected]> wrote:
>
> clang with W=1 reports
> drivers/gpu/drm/gma500/psb_irq.c:35:19: error: unused function
> 'gma_pipe_event' [-Werror,-Wunused-function]
> static inline u32 gma_pipe_event(int pipe)
> ^
> This function is not used, so remove it.
>
> Signed-off-by: Tom Rix <[email protected]>

Applied to drm-misc-next

Thanks
Patrik

> ---
> drivers/gpu/drm/gma500/psb_irq.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/psb_irq.c b/drivers/gpu/drm/gma500/psb_irq.c
> index d421031462df..343c51250207 100644
> --- a/drivers/gpu/drm/gma500/psb_irq.c
> +++ b/drivers/gpu/drm/gma500/psb_irq.c
> @@ -32,17 +32,6 @@ static inline u32 gma_pipestat(int pipe)
> BUG();
> }
>
> -static inline u32 gma_pipe_event(int pipe)
> -{
> - if (pipe == 0)
> - return _PSB_PIPEA_EVENT_FLAG;
> - if (pipe == 1)
> - return _MDFLD_PIPEB_EVENT_FLAG;
> - if (pipe == 2)
> - return _MDFLD_PIPEC_EVENT_FLAG;
> - BUG();
> -}
> -
> static inline u32 gma_pipeconf(int pipe)
> {
> if (pipe == 0)
> --
> 2.27.0
>