Watchdog nodes must use 'watchdog' for node name. When a 'make dtbs_check'
is performed the following warning appears:
wdt@100: $nodename:0: 'wdt@100' does not match '^watchdog(@.*|-[0-9a-f])?$'
Fix this warning up properly renaming the node into 'watchdog'.
Reviewed-by: Arınç ÜNAL <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Signed-off-by: Sergio Paracuellos <[email protected]>
---
arch/mips/boot/dts/ralink/mt7621.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
index 5ca40fd21662..ac818fd721ae 100644
--- a/arch/mips/boot/dts/ralink/mt7621.dtsi
+++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
@@ -70,7 +70,7 @@ sysc: syscon@0 {
"250m", "270m";
};
- wdt: wdt@100 {
+ wdt: watchdog@100 {
compatible = "mediatek,mt7621-wdt";
reg = <0x100 0x100>;
};
--
2.25.1
On Tue, Feb 14, 2023 at 11:39:33AM +0100, Sergio Paracuellos wrote:
> Watchdog nodes must use 'watchdog' for node name. When a 'make dtbs_check'
> is performed the following warning appears:
>
> wdt@100: $nodename:0: 'wdt@100' does not match '^watchdog(@.*|-[0-9a-f])?$'
>
> Fix this warning up properly renaming the node into 'watchdog'.
>
> Reviewed-by: Arınç ÜNAL <[email protected]>
> Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
> Signed-off-by: Sergio Paracuellos <[email protected]>
Acked-by: Guenter Roeck <[email protected]>
Note that we can not apply this and the next patch of the series
through the watchdog tree since it crosses a maintainer boundary.
Guenter
> ---
> arch/mips/boot/dts/ralink/mt7621.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
> index 5ca40fd21662..ac818fd721ae 100644
> --- a/arch/mips/boot/dts/ralink/mt7621.dtsi
> +++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
> @@ -70,7 +70,7 @@ sysc: syscon@0 {
> "250m", "270m";
> };
>
> - wdt: wdt@100 {
> + wdt: watchdog@100 {
> compatible = "mediatek,mt7621-wdt";
> reg = <0x100 0x100>;
> };
> --
> 2.25.1
>
On Tue, Feb 14, 2023 at 4:11 PM Guenter Roeck <[email protected]> wrote:
>
> On Tue, Feb 14, 2023 at 11:39:33AM +0100, Sergio Paracuellos wrote:
> > Watchdog nodes must use 'watchdog' for node name. When a 'make dtbs_check'
> > is performed the following warning appears:
> >
> > wdt@100: $nodename:0: 'wdt@100' does not match '^watchdog(@.*|-[0-9a-f])?$'
> >
> > Fix this warning up properly renaming the node into 'watchdog'.
> >
> > Reviewed-by: Arınç ÜNAL <[email protected]>
> > Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
> > Signed-off-by: Sergio Paracuellos <[email protected]>
>
> Acked-by: Guenter Roeck <[email protected]>
>
> Note that we can not apply this and the next patch of the series
> through the watchdog tree since it crosses a maintainer boundary.
I was expecting Thomas to get these two arch/mips patches or get an
Acked-by from him in order for you to apply them.
Thanks,
Sergio Paracuellos
>
> Guenter
>
> > ---
> > arch/mips/boot/dts/ralink/mt7621.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
> > index 5ca40fd21662..ac818fd721ae 100644
> > --- a/arch/mips/boot/dts/ralink/mt7621.dtsi
> > +++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
> > @@ -70,7 +70,7 @@ sysc: syscon@0 {
> > "250m", "270m";
> > };
> >
> > - wdt: wdt@100 {
> > + wdt: watchdog@100 {
> > compatible = "mediatek,mt7621-wdt";
> > reg = <0x100 0x100>;
> > };
> > --
> > 2.25.1
> >
On Tue, Feb 14, 2023 at 4:12 PM Sergio Paracuellos
<[email protected]> wrote:
>
> On Tue, Feb 14, 2023 at 4:11 PM Guenter Roeck <[email protected]> wrote:
> >
> > On Tue, Feb 14, 2023 at 11:39:33AM +0100, Sergio Paracuellos wrote:
> > > Watchdog nodes must use 'watchdog' for node name. When a 'make dtbs_check'
> > > is performed the following warning appears:
> > >
> > > wdt@100: $nodename:0: 'wdt@100' does not match '^watchdog(@.*|-[0-9a-f])?$'
> > >
> > > Fix this warning up properly renaming the node into 'watchdog'.
> > >
> > > Reviewed-by: Arınç ÜNAL <[email protected]>
> > > Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
> > > Signed-off-by: Sergio Paracuellos <[email protected]>
> >
> > Acked-by: Guenter Roeck <[email protected]>
> >
> > Note that we can not apply this and the next patch of the series
> > through the watchdog tree since it crosses a maintainer boundary.
>
> I was expecting Thomas to get these two arch/mips patches or get an
> Acked-by from him in order for you to apply them.
Hi Thomas,
I think you have missed this series since you have started to apply
newer stuff in mips-next. Are you ok with taking or Acking patches 2
and 3 of this series?
Thanks,
Sergio Paracuellos
>
> Thanks,
> Sergio Paracuellos
>
> >
> > Guenter
> >
> > > ---
> > > arch/mips/boot/dts/ralink/mt7621.dtsi | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
> > > index 5ca40fd21662..ac818fd721ae 100644
> > > --- a/arch/mips/boot/dts/ralink/mt7621.dtsi
> > > +++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
> > > @@ -70,7 +70,7 @@ sysc: syscon@0 {
> > > "250m", "270m";
> > > };
> > >
> > > - wdt: wdt@100 {
> > > + wdt: watchdog@100 {
> > > compatible = "mediatek,mt7621-wdt";
> > > reg = <0x100 0x100>;
> > > };
> > > --
> > > 2.25.1
> > >
On Tue, Feb 28, 2023 at 05:44:21AM +0100, Sergio Paracuellos wrote:
> On Tue, Feb 14, 2023 at 4:12 PM Sergio Paracuellos
> <[email protected]> wrote:
> >
> > On Tue, Feb 14, 2023 at 4:11 PM Guenter Roeck <[email protected]> wrote:
> > >
> > > On Tue, Feb 14, 2023 at 11:39:33AM +0100, Sergio Paracuellos wrote:
> > > > Watchdog nodes must use 'watchdog' for node name. When a 'make dtbs_check'
> > > > is performed the following warning appears:
> > > >
> > > > wdt@100: $nodename:0: 'wdt@100' does not match '^watchdog(@.*|-[0-9a-f])?$'
> > > >
> > > > Fix this warning up properly renaming the node into 'watchdog'.
> > > >
> > > > Reviewed-by: Arınç ÜNAL <[email protected]>
> > > > Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
> > > > Signed-off-by: Sergio Paracuellos <[email protected]>
> > >
> > > Acked-by: Guenter Roeck <[email protected]>
> > >
> > > Note that we can not apply this and the next patch of the series
> > > through the watchdog tree since it crosses a maintainer boundary.
> >
> > I was expecting Thomas to get these two arch/mips patches or get an
> > Acked-by from him in order for you to apply them.
>
> Hi Thomas,
>
> I think you have missed this series since you have started to apply
> newer stuff in mips-next. Are you ok with taking or Acking patches 2
> and 3 of this series?
yes, I sort of missed it. If it's enough to take patch 2/3 I'll do that.
If it's better to keep the series, I'm also ok with acking them.
What's the best way forward ?
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
On Tue, Feb 28, 2023 at 9:41 AM Thomas Bogendoerfer
<[email protected]> wrote:
>
> On Tue, Feb 28, 2023 at 05:44:21AM +0100, Sergio Paracuellos wrote:
> > On Tue, Feb 14, 2023 at 4:12 PM Sergio Paracuellos
> > <[email protected]> wrote:
> > >
> > > On Tue, Feb 14, 2023 at 4:11 PM Guenter Roeck <[email protected]> wrote:
> > > >
> > > > On Tue, Feb 14, 2023 at 11:39:33AM +0100, Sergio Paracuellos wrote:
> > > > > Watchdog nodes must use 'watchdog' for node name. When a 'make dtbs_check'
> > > > > is performed the following warning appears:
> > > > >
> > > > > wdt@100: $nodename:0: 'wdt@100' does not match '^watchdog(@.*|-[0-9a-f])?$'
> > > > >
> > > > > Fix this warning up properly renaming the node into 'watchdog'.
> > > > >
> > > > > Reviewed-by: Arınç ÜNAL <[email protected]>
> > > > > Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
> > > > > Signed-off-by: Sergio Paracuellos <[email protected]>
> > > >
> > > > Acked-by: Guenter Roeck <[email protected]>
> > > >
> > > > Note that we can not apply this and the next patch of the series
> > > > through the watchdog tree since it crosses a maintainer boundary.
> > >
> > > I was expecting Thomas to get these two arch/mips patches or get an
> > > Acked-by from him in order for you to apply them.
> >
> > Hi Thomas,
> >
> > I think you have missed this series since you have started to apply
> > newer stuff in mips-next. Are you ok with taking or Acking patches 2
> > and 3 of this series?
>
> yes, I sort of missed it. If it's enough to take patch 2/3 I'll do that.
> If it's better to keep the series, I'm also ok with acking them.
> What's the best way forward ?
Both trees work for me. The rest of the patches of this series should
go through the watchdog tree. Guenter, what is better for you?
Thanks,
Sergio Paracuellos
>
> Thomas.
>
> --
> Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
> good idea. [ RFC1925, 2.3 ]
On 2/28/23 00:51, Sergio Paracuellos wrote:
> On Tue, Feb 28, 2023 at 9:41 AM Thomas Bogendoerfer
> <[email protected]> wrote:
>>
>> On Tue, Feb 28, 2023 at 05:44:21AM +0100, Sergio Paracuellos wrote:
>>> On Tue, Feb 14, 2023 at 4:12 PM Sergio Paracuellos
>>> <[email protected]> wrote:
>>>>
>>>> On Tue, Feb 14, 2023 at 4:11 PM Guenter Roeck <[email protected]> wrote:
>>>>>
>>>>> On Tue, Feb 14, 2023 at 11:39:33AM +0100, Sergio Paracuellos wrote:
>>>>>> Watchdog nodes must use 'watchdog' for node name. When a 'make dtbs_check'
>>>>>> is performed the following warning appears:
>>>>>>
>>>>>> wdt@100: $nodename:0: 'wdt@100' does not match '^watchdog(@.*|-[0-9a-f])?$'
>>>>>>
>>>>>> Fix this warning up properly renaming the node into 'watchdog'.
>>>>>>
>>>>>> Reviewed-by: Arınç ÜNAL <[email protected]>
>>>>>> Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
>>>>>> Signed-off-by: Sergio Paracuellos <[email protected]>
>>>>>
>>>>> Acked-by: Guenter Roeck <[email protected]>
>>>>>
>>>>> Note that we can not apply this and the next patch of the series
>>>>> through the watchdog tree since it crosses a maintainer boundary.
>>>>
>>>> I was expecting Thomas to get these two arch/mips patches or get an
>>>> Acked-by from him in order for you to apply them.
>>>
>>> Hi Thomas,
>>>
>>> I think you have missed this series since you have started to apply
>>> newer stuff in mips-next. Are you ok with taking or Acking patches 2
>>> and 3 of this series?
>>
>> yes, I sort of missed it. If it's enough to take patch 2/3 I'll do that.
>> If it's better to keep the series, I'm also ok with acking them.
>> What's the best way forward ?
>
> Both trees work for me. The rest of the patches of this series should
> go through the watchdog tree. Guenter, what is better for you?
>
Wim is handling pull requests. He has queued the other three patches in his
tree. I would suggest to apply the two remaining patches through the mips
tree.
Guenter
> Thanks,
> Sergio Paracuellos
>
>>
>> Thomas.
>>
>> --
>> Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
>> good idea. [ RFC1925, 2.3 ]
On Tue, Feb 28, 2023 at 3:55 PM Guenter Roeck <[email protected]> wrote:
>
> On 2/28/23 00:51, Sergio Paracuellos wrote:
> > On Tue, Feb 28, 2023 at 9:41 AM Thomas Bogendoerfer
> > <[email protected]> wrote:
> >>
> >> On Tue, Feb 28, 2023 at 05:44:21AM +0100, Sergio Paracuellos wrote:
> >>> On Tue, Feb 14, 2023 at 4:12 PM Sergio Paracuellos
> >>> <[email protected]> wrote:
> >>>>
> >>>> On Tue, Feb 14, 2023 at 4:11 PM Guenter Roeck <[email protected]> wrote:
> >>>>>
> >>>>> On Tue, Feb 14, 2023 at 11:39:33AM +0100, Sergio Paracuellos wrote:
> >>>>>> Watchdog nodes must use 'watchdog' for node name. When a 'make dtbs_check'
> >>>>>> is performed the following warning appears:
> >>>>>>
> >>>>>> wdt@100: $nodename:0: 'wdt@100' does not match '^watchdog(@.*|-[0-9a-f])?$'
> >>>>>>
> >>>>>> Fix this warning up properly renaming the node into 'watchdog'.
> >>>>>>
> >>>>>> Reviewed-by: Arınç ÜNAL <[email protected]>
> >>>>>> Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
> >>>>>> Signed-off-by: Sergio Paracuellos <[email protected]>
> >>>>>
> >>>>> Acked-by: Guenter Roeck <[email protected]>
> >>>>>
> >>>>> Note that we can not apply this and the next patch of the series
> >>>>> through the watchdog tree since it crosses a maintainer boundary.
> >>>>
> >>>> I was expecting Thomas to get these two arch/mips patches or get an
> >>>> Acked-by from him in order for you to apply them.
> >>>
> >>> Hi Thomas,
> >>>
> >>> I think you have missed this series since you have started to apply
> >>> newer stuff in mips-next. Are you ok with taking or Acking patches 2
> >>> and 3 of this series?
> >>
> >> yes, I sort of missed it. If it's enough to take patch 2/3 I'll do that.
> >> If it's better to keep the series, I'm also ok with acking them.
> >> What's the best way forward ?
> >
> > Both trees work for me. The rest of the patches of this series should
> > go through the watchdog tree. Guenter, what is better for you?
> >
>
> Wim is handling pull requests. He has queued the other three patches in his
> tree. I would suggest to apply the two remaining patches through the mips
> tree.
Thanks for letting me know, Guenter.
Thomas, please, take the patches 2 and 3 through the mips tree, then.
Thanks,
Sergio Paracuellos
>
> Guenter
>
> > Thanks,
> > Sergio Paracuellos
> >
> >>
> >> Thomas.
> >>
> >> --
> >> Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
> >> good idea. [ RFC1925, 2.3 ]
>
On Tue, Feb 14, 2023 at 11:39:33AM +0100, Sergio Paracuellos wrote:
> Watchdog nodes must use 'watchdog' for node name. When a 'make dtbs_check'
> is performed the following warning appears:
>
> wdt@100: $nodename:0: 'wdt@100' does not match '^watchdog(@.*|-[0-9a-f])?$'
>
> Fix this warning up properly renaming the node into 'watchdog'.
>
> Reviewed-by: Arınç ÜNAL <[email protected]>
> Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
> Signed-off-by: Sergio Paracuellos <[email protected]>
> ---
> arch/mips/boot/dts/ralink/mt7621.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
> index 5ca40fd21662..ac818fd721ae 100644
> --- a/arch/mips/boot/dts/ralink/mt7621.dtsi
> +++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
> @@ -70,7 +70,7 @@ sysc: syscon@0 {
> "250m", "270m";
> };
>
> - wdt: wdt@100 {
> + wdt: watchdog@100 {
> compatible = "mediatek,mt7621-wdt";
> reg = <0x100 0x100>;
> };
> --
> 2.25.1
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]