2022-08-25 11:36:25

by Sakari Ailus

Subject: [PATCH 1/1] acpi: Remove default association from integer maximum values

Remove the default association from integer maximum value checks. It is
not necessary and has caused a bug in other associations being unnoticed.

Fixes: 923044133367 ("ACPI: property: Unify integer value reading functions")
Signed-off-by: Sakari Ailus <[email protected]>
---
drivers/acpi/property.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
index 91d0e75859d37..d4c168ce428ca 100644
--- a/drivers/acpi/property.c
+++ b/drivers/acpi/property.c
@@ -1046,8 +1046,7 @@ static int acpi_data_prop_read_single(const struct acpi_device_data *data,
u8 *: U8_MAX, \
u16 *: U16_MAX, \
u32 *: U32_MAX, \
- u64 *: U64_MAX, \
- default: 0U)) { \
+ u64 *: U64_MAX)) { \
ret = -EOVERFLOW; \
break; \
} \
--
2.30.2

2022-08-26 10:59:19

by Ard Biesheuvel

Subject: Re: [PATCH 1/1] acpi: Remove default association from integer maximum values

On Thu, 25 Aug 2022 at 13:17, Sakari Ailus <[email protected]> wrote:
>
> Remove the default association from integer maximum value checks. It is
> not necessary and has caused a bug in other associations being unnoticed.
>
> Fixes: 923044133367 ("ACPI: property: Unify integer value reading functions")
> Signed-off-by: Sakari Ailus <[email protected]>

Acked-by: Ard Biesheuvel <[email protected]>

> ---
> drivers/acpi/property.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
> index 91d0e75859d37..d4c168ce428ca 100644
> --- a/drivers/acpi/property.c
> +++ b/drivers/acpi/property.c
> @@ -1046,8 +1046,7 @@ static int acpi_data_prop_read_single(const struct acpi_device_data *data,
> u8 *: U8_MAX, \
> u16 *: U16_MAX, \
> u32 *: U32_MAX, \
> - u64 *: U64_MAX, \
> - default: 0U)) { \
> + u64 *: U64_MAX)) { \
> ret = -EOVERFLOW; \
> break; \
> } \
> --
> 2.30.2
>