2022-08-31 02:36:21

by Michel Lespinasse

Subject: [PATCH 1/4] Remove unused variable et in efi_get_system_table()

This avoids a build warning with CONFIG_EFI enabled.

Fixes: 7c4146e88855 (x86/compressed/acpi: Move EFI detection to helper)
Signed-off-by: Michel Lespinasse <[email protected]>
---
arch/x86/boot/compressed/efi.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/x86/boot/compressed/efi.c b/arch/x86/boot/compressed/efi.c
index 6edd034b0b30..c42ee7874eb9 100644
--- a/arch/x86/boot/compressed/efi.c
+++ b/arch/x86/boot/compressed/efi.c
@@ -59,7 +59,6 @@ unsigned long efi_get_system_table(struct boot_params *bp)
{
unsigned long sys_tbl_pa;
struct efi_info *ei;
- enum efi_type et;

/* Get systab from boot params. */
ei = &bp->efi_info;
--
2.20.1

2022-09-05 11:10:57

by Ard Biesheuvel

Subject: Re: [PATCH 1/4] Remove unused variable et in efi_get_system_table()

On Wed, 31 Aug 2022 at 03:12, Michel Lespinasse <[email protected]> wrote:
>
> This avoids a build warning with CONFIG_EFI enabled.
>
> Fixes: 7c4146e88855 (x86/compressed/acpi: Move EFI detection to helper)

Please use " inside the ()

Also, the commit id looks wrong to me.

> Signed-off-by: Michel Lespinasse <[email protected]>
> ---
> arch/x86/boot/compressed/efi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/boot/compressed/efi.c b/arch/x86/boot/compressed/efi.c
> index 6edd034b0b30..c42ee7874eb9 100644
> --- a/arch/x86/boot/compressed/efi.c
> +++ b/arch/x86/boot/compressed/efi.c
> @@ -59,7 +59,6 @@ unsigned long efi_get_system_table(struct boot_params *bp)
> {
> unsigned long sys_tbl_pa;
> struct efi_info *ei;
> - enum efi_type et;
>
> /* Get systab from boot params. */
> ei = &bp->efi_info;
> --
> 2.20.1
>