2014-04-12 01:32:56

by Steven Miao

[permalink] [raw]

Subject: [PATCH] video: bf54x-lq043fb: fix build error

---

From: Steven Miao <[email protected]>

should include linux/gpio.h

Signed-off-by: Steven Miao <[email protected]>
---
drivers/video/bf54x-lq043fb.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/video/bf54x-lq043fb.c b/drivers/video/bf54x-lq043fb.c
index 42b8f9d..d2b54f1 100644
--- a/drivers/video/bf54x-lq043fb.c
+++ b/drivers/video/bf54x-lq043fb.c
@@ -49,6 +49,7 @@
#include <linux/spinlock.h>
#include <linux/dma-mapping.h>
#include <linux/platform_device.h>
+#include <linux/gpio.h>

#include <asm/blackfin.h>
#include <asm/irq.h>
--
1.7.9.5

2014-04-14 12:44:15

by Tomi Valkeinen

[permalink] [raw]

Subject: Re: [PATCH] video: bf54x-lq043fb: fix build error

---

On 12/04/14 04:30, Steven Miao wrote:
> From: Steven Miao <[email protected]>
>
> should include linux/gpio.h
>
> Signed-off-by: Steven Miao <[email protected]>
> ---
> drivers/video/bf54x-lq043fb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/bf54x-lq043fb.c b/drivers/video/bf54x-lq043fb.c
> index 42b8f9d..d2b54f1 100644
> --- a/drivers/video/bf54x-lq043fb.c
> +++ b/drivers/video/bf54x-lq043fb.c
> @@ -49,6 +49,7 @@
> #include <linux/spinlock.h>
> #include <linux/dma-mapping.h>
> #include <linux/platform_device.h>
> +#include <linux/gpio.h>

The driver includes <asm/gpio.h>. I think that should be removed, and
<linux/gpio.h> should be used.

Can you also remove the asm/gpio.h in your patch, and see if it compiles
fine?

Tomi

---

Attachments:

signature.asc (836.00 B)
OpenPGP digital signature

2014-04-15 06:35:09

by Steven Miao

[permalink] [raw]

Subject: Re: [PATCH] video: bf54x-lq043fb: fix build error

---

Hi Tomi,

On Mon, Apr 14, 2014 at 8:44 PM, Tomi Valkeinen <[email protected]> wrote:
> On 12/04/14 04:30, Steven Miao wrote:
>> From: Steven Miao <[email protected]>
>>
>> should include linux/gpio.h
>>
>> Signed-off-by: Steven Miao <[email protected]>
>> ---
>> drivers/video/bf54x-lq043fb.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/video/bf54x-lq043fb.c b/drivers/video/bf54x-lq043fb.c
>> index 42b8f9d..d2b54f1 100644
>> --- a/drivers/video/bf54x-lq043fb.c
>> +++ b/drivers/video/bf54x-lq043fb.c
>> @@ -49,6 +49,7 @@
>> #include <linux/spinlock.h>
>> #include <linux/dma-mapping.h>
>> #include <linux/platform_device.h>
>> +#include <linux/gpio.h>
>
> The driver includes <asm/gpio.h>. I think that should be removed, and
> <linux/gpio.h> should be used.
Yes, it should be removed.
>
> Can you also remove the asm/gpio.h in your patch, and see if it compiles
> fine?
I have tested it, it's fine. I'll resend the patch.
>
> Tomi
>
>
-steven