2023-09-20 08:38:51

by Randy Dunlap

Subject: [PATCH 16/16] xtensa: boot/lib: add missing prototypes for functions

Add function prototypes for exit(), zalloc(), and gunzip() to the
boot library code.

arch/xtensa/boot/lib/zmem.c:8:6: warning: no previous prototype for 'exit' [-Wmissing-prototypes]
8 | void exit (void)
arch/xtensa/boot/lib/zmem.c:13:7: warning: no previous prototype for 'zalloc' [-Wmissing-prototypes]
13 | void *zalloc(unsigned size)
arch/xtensa/boot/lib/zmem.c:35:6: warning: no previous prototype for 'gunzip' [-Wmissing-prototypes]
35 | void gunzip (void *dst, int dstlen, unsigned char *src, int *lenp)

Fixes: 4bedea945451 ("xtensa: Architecture support for Tensilica Xtensa Part 2")
Fixes: e7d163f76665 ("xtensa: Removed local copy of zlib and fixed O= support")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Chris Zankel <[email protected]>
Cc: Max Filippov <[email protected]>
---
arch/xtensa/boot/lib/zmem.c | 4 ++++
1 file changed, 4 insertions(+)

diff -- a/arch/xtensa/boot/lib/zmem.c b/arch/xtensa/boot/lib/zmem.c
--- a/arch/xtensa/boot/lib/zmem.c
+++ b/arch/xtensa/boot/lib/zmem.c
@@ -5,6 +5,10 @@

extern void *avail_ram, *end_avail;

+void exit (void);
+void *zalloc(unsigned size);
+void gunzip (void *dst, int dstlen, unsigned char *src, int *lenp);
+
void exit (void)
{
for (;;);

2023-09-20 21:55:47

by Max Filippov

Subject: Re: [PATCH 16/16] xtensa: boot/lib: add missing prototypes for functions

On Tue, Sep 19, 2023 at 10:21 PM Randy Dunlap <[email protected]> wrote:
>
> Add function prototypes for exit(), zalloc(), and gunzip() to the
> boot library code.

exit() and zalloc() don't need to be public. I've posted a different fix that
makes these two functions static.


> arch/xtensa/boot/lib/zmem.c:8:6: warning: no previous prototype for 'exit' [-Wmissing-prototypes]
> 8 | void exit (void)
> arch/xtensa/boot/lib/zmem.c:13:7: warning: no previous prototype for 'zalloc' [-Wmissing-prototypes]
> 13 | void *zalloc(unsigned size)
> arch/xtensa/boot/lib/zmem.c:35:6: warning: no previous prototype for 'gunzip' [-Wmissing-prototypes]
> 35 | void gunzip (void *dst, int dstlen, unsigned char *src, int *lenp)
>
> Fixes: 4bedea945451 ("xtensa: Architecture support for Tensilica Xtensa Part 2")
> Fixes: e7d163f76665 ("xtensa: Removed local copy of zlib and fixed O= support")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Chris Zankel <[email protected]>
> Cc: Max Filippov <[email protected]>
> ---
> arch/xtensa/boot/lib/zmem.c | 4 ++++
> 1 file changed, 4 insertions(+)

--
Thanks.
-- Max