2020-01-08 12:13:09

by Yue Haibing

Subject: [PATCH -next] gpiolib: remove set but not used variable 'config'

drivers/gpio/gpiolib.c: In function gpio_set_config:
drivers/gpio/gpiolib.c:3053:16: warning:
variable config set but not used [-Wunused-but-set-variable]

commit d90f36851d65 ("gpiolib: have a single place
of calling set_config()") left behind this unused variable.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: YueHaibing <[email protected]>
---
drivers/gpio/gpiolib.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 9fd2dfb..aabf801 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -3050,7 +3050,6 @@ static int gpio_do_set_config(struct gpio_chip *gc, unsigned int offset,
static int gpio_set_config(struct gpio_chip *gc, unsigned int offset,
enum pin_config_param mode)
{
- unsigned long config;
unsigned arg;

switch (mode) {
@@ -3064,7 +3063,6 @@ static int gpio_set_config(struct gpio_chip *gc, unsigned int offset,
arg = 0;
}

- config = PIN_CONF_PACKED(mode, arg);
return gpio_do_set_config(gc, offset, mode);
}

--
2.7.4

2020-01-08 14:21:14

by Bartosz Golaszewski

Subject: Re: [PATCH -next] gpiolib: remove set but not used variable 'config'

śr., 8 sty 2020 o 13:11 YueHaibing <[email protected]> napisał(a):
>
> drivers/gpio/gpiolib.c: In function gpio_set_config:
> drivers/gpio/gpiolib.c:3053:16: warning:
> variable config set but not used [-Wunused-but-set-variable]
>
> commit d90f36851d65 ("gpiolib: have a single place
> of calling set_config()") left behind this unused variable.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/gpio/gpiolib.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index 9fd2dfb..aabf801 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -3050,7 +3050,6 @@ static int gpio_do_set_config(struct gpio_chip *gc, unsigned int offset,
> static int gpio_set_config(struct gpio_chip *gc, unsigned int offset,
> enum pin_config_param mode)
> {
> - unsigned long config;
> unsigned arg;
>
> switch (mode) {
> @@ -3064,7 +3063,6 @@ static int gpio_set_config(struct gpio_chip *gc, unsigned int offset,
> arg = 0;
> }
>
> - config = PIN_CONF_PACKED(mode, arg);
> return gpio_do_set_config(gc, offset, mode);
> }
>

Reviewed-by: Bartosz Golaszewski <[email protected]>

Thanks!

2020-01-15 13:40:59

by Linus Walleij

Subject: Re: [PATCH -next] gpiolib: remove set but not used variable 'config'

On Wed, Jan 8, 2020 at 1:11 PM YueHaibing <[email protected]> wrote:

> drivers/gpio/gpiolib.c: In function gpio_set_config:
> drivers/gpio/gpiolib.c:3053:16: warning:
> variable config set but not used [-Wunused-but-set-variable]
>
> commit d90f36851d65 ("gpiolib: have a single place
> of calling set_config()") left behind this unused variable.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>

Patch applied with Bartosz' review tag.

Yours,
Linus Walleij