2024-04-09 18:47:38

by Andy Shevchenko

Subject: [PATCH v1 1/1] auxdisplay: charlcd: Don't rebuild when CONFIG_PANEL_BOOT_MESSAGE=y

When CONFIG_PANEL_BOOT_MESSAGE=y the module still includes
the generated header and gets rebuilt even if it doesn't use
anything from that header. Include generated header conditionally
to avoid unnecessary rebuilds.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/auxdisplay/charlcd.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/auxdisplay/charlcd.c b/drivers/auxdisplay/charlcd.c
index 5df019720c56..bb9463814454 100644
--- a/drivers/auxdisplay/charlcd.c
+++ b/drivers/auxdisplay/charlcd.c
@@ -17,7 +17,9 @@
#include <linux/uaccess.h>
#include <linux/workqueue.h>

+#ifndef CONFIG_PANEL_BOOT_MESSAGE
#include <generated/utsrelease.h>
+#endif

#include "charlcd.h"

--
2.43.0.rc1.1.gbec44491f096

2024-04-11 08:07:29

by Geert Uytterhoeven

Subject: Re: [PATCH v1 1/1] auxdisplay: charlcd: Don't rebuild when CONFIG_PANEL_BOOT_MESSAGE=y

Hi Andy,

On Tue, Apr 9, 2024 at 7:39 PM Andy Shevchenko
<[email protected]> wrote:
> When CONFIG_PANEL_BOOT_MESSAGE=y the module still includes
> the generated header and gets rebuilt even if it doesn't use
> anything from that header. Include generated header conditionally
> to avoid unnecessary rebuilds.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Thanks for your patch!

> --- a/drivers/auxdisplay/charlcd.c
> +++ b/drivers/auxdisplay/charlcd.c
> @@ -17,7 +17,9 @@
> #include <linux/uaccess.h>
> #include <linux/workqueue.h>
>
> +#ifndef CONFIG_PANEL_BOOT_MESSAGE
> #include <generated/utsrelease.h>
> +#endif

Perhaps move the existing "#ifdef CONFIG_PANEL_BOOT_MESSAGE"-block
up, and move the #include inside the #else branch?

>
> #include "charlcd.h"

Regardless
Reviewed-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2024-04-11 15:43:22

by Andy Shevchenko

Subject: Re: [PATCH v1 1/1] auxdisplay: charlcd: Don't rebuild when CONFIG_PANEL_BOOT_MESSAGE=y

On Thu, Apr 11, 2024 at 09:43:48AM +0200, Geert Uytterhoeven wrote:
> On Tue, Apr 9, 2024 at 7:39 PM Andy Shevchenko
> <[email protected]> wrote:
> > When CONFIG_PANEL_BOOT_MESSAGE=y the module still includes
> > the generated header and gets rebuilt even if it doesn't use
> > anything from that header. Include generated header conditionally
> > to avoid unnecessary rebuilds.
> >
> > Signed-off-by: Andy Shevchenko <[email protected]>
>
> Thanks for your patch!
>
> > --- a/drivers/auxdisplay/charlcd.c
> > +++ b/drivers/auxdisplay/charlcd.c
> > @@ -17,7 +17,9 @@
> > #include <linux/uaccess.h>
> > #include <linux/workqueue.h>
> >
> > +#ifndef CONFIG_PANEL_BOOT_MESSAGE
> > #include <generated/utsrelease.h>
> > +#endif
>
> Perhaps move the existing "#ifdef CONFIG_PANEL_BOOT_MESSAGE"-block
> up, and move the #include inside the #else branch?

I was thinking about it, but decided to group headers together.

> > #include "charlcd.h"
>
> Regardless
> Reviewed-by: Geert Uytterhoeven <[email protected]>

Pushed to my review and testing queue, thanks!

--
With Best Regards,
Andy Shevchenko