2021-02-07 07:09:56

by Finn Thain

[permalink] [raw]
Subject: [PATCH] m68k: Drop -fno-strength-reduce from KBUILD_CFLAGS

This workaround became redundant either when the driver in question was
removed (in Linux v2.6.23) or when the compiler flag became a no-op
(in GCC v4.2). Linux has required GCC v4.6 or later since v4.19.

Link: https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=efa1cdf01850b28c2f6f7035ebd4420259494615
References: commit 565bae6a4a8f ("[SCSI] 53c7xx: kill driver")
References: commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6")
Signed-off-by: Finn Thain <[email protected]>
---
arch/m68k/Makefile | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/m68k/Makefile b/arch/m68k/Makefile
index ea14f2046fb4..5be4efec173a 100644
--- a/arch/m68k/Makefile
+++ b/arch/m68k/Makefile
@@ -66,8 +66,7 @@ KBUILD_CFLAGS += $(cpuflags-y)
KBUILD_CFLAGS += -pipe -ffreestanding

ifdef CONFIG_MMU
-# without -fno-strength-reduce the 53c7xx.c driver fails ;-(
-KBUILD_CFLAGS += -fno-strength-reduce -ffixed-a2
+KBUILD_CFLAGS += -ffixed-a2
else
# we can use a m68k-linux-gcc toolchain with these in place
KBUILD_CPPFLAGS += -DUTS_SYSNAME=\"uClinux\"
--
2.26.2


Subject: Re: [PATCH] m68k: Drop -fno-strength-reduce from KBUILD_CFLAGS

On 2/7/21 8:02 AM, Finn Thain wrote:
> References: commit 565bae6a4a8f ("[SCSI] 53c7xx: kill driver")

Does that mean there is currently no driver for the A4091?

Adrian

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - [email protected]
`. `' Freie Universitaet Berlin - [email protected]
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913

2021-02-07 09:47:37

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] m68k: Drop -fno-strength-reduce from KBUILD_CFLAGS

Hi Adrian,

On Sun, Feb 7, 2021 at 9:51 AM John Paul Adrian Glaubitz
<[email protected]> wrote:
> On 2/7/21 8:02 AM, Finn Thain wrote:
> > References: commit 565bae6a4a8f ("[SCSI] 53c7xx: kill driver")
>
> Does that mean there is currently no driver for the A4091?

Supported by the replacement driver:
45804fbb00eea27b ("[SCSI] 53c700: Amiga Zorro NCR53c710 SCSI")

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2021-05-06 00:34:10

by Finn Thain

[permalink] [raw]
Subject: Re: [PATCH] m68k: Drop -fno-strength-reduce from KBUILD_CFLAGS

Ping...

On Sun, 7 Feb 2021, Finn Thain wrote:

> This workaround became redundant either when the driver in question was
> removed (in Linux v2.6.23) or when the compiler flag became a no-op
> (in GCC v4.2). Linux has required GCC v4.6 or later since v4.19.
>
> Link: https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=efa1cdf01850b28c2f6f7035ebd4420259494615
> References: commit 565bae6a4a8f ("[SCSI] 53c7xx: kill driver")
> References: commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6")
> Signed-off-by: Finn Thain <[email protected]>
> ---
> arch/m68k/Makefile | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/m68k/Makefile b/arch/m68k/Makefile
> index ea14f2046fb4..5be4efec173a 100644
> --- a/arch/m68k/Makefile
> +++ b/arch/m68k/Makefile
> @@ -66,8 +66,7 @@ KBUILD_CFLAGS += $(cpuflags-y)
> KBUILD_CFLAGS += -pipe -ffreestanding
>
> ifdef CONFIG_MMU
> -# without -fno-strength-reduce the 53c7xx.c driver fails ;-(
> -KBUILD_CFLAGS += -fno-strength-reduce -ffixed-a2
> +KBUILD_CFLAGS += -ffixed-a2
> else
> # we can use a m68k-linux-gcc toolchain with these in place
> KBUILD_CPPFLAGS += -DUTS_SYSNAME=\"uClinux\"
>

2021-05-06 07:21:24

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] m68k: Drop -fno-strength-reduce from KBUILD_CFLAGS

On Sun, Feb 7, 2021 at 8:08 AM Finn Thain <[email protected]> wrote:
> This workaround became redundant either when the driver in question was
> removed (in Linux v2.6.23) or when the compiler flag became a no-op
> (in GCC v4.2). Linux has required GCC v4.6 or later since v4.19.
>
> Link: https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=efa1cdf01850b28c2f6f7035ebd4420259494615
> References: commit 565bae6a4a8f ("[SCSI] 53c7xx: kill driver")
> References: commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6")
> Signed-off-by: Finn Thain <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>
i.e. will queue in the m68k for-v5.14 branch.

> --- a/arch/m68k/Makefile
> +++ b/arch/m68k/Makefile
> @@ -66,8 +66,7 @@ KBUILD_CFLAGS += $(cpuflags-y)
> KBUILD_CFLAGS += -pipe -ffreestanding
>
> ifdef CONFIG_MMU
> -# without -fno-strength-reduce the 53c7xx.c driver fails ;-(
> -KBUILD_CFLAGS += -fno-strength-reduce -ffixed-a2
> +KBUILD_CFLAGS += -ffixed-a2
> else
> # we can use a m68k-linux-gcc toolchain with these in place
> KBUILD_CPPFLAGS += -DUTS_SYSNAME=\"uClinux\"

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds