2021-11-05 03:21:13

by Xu Wang

Subject: [PATCH] iio: adc: rzg2l_adc: Remove unnecessary print function dev_err()

The print function dev_err() is redundant because
platform_get_irq() already prints an error.

Signed-off-by: Xu Wang <[email protected]>
---
drivers/iio/adc/rzg2l_adc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/iio/adc/rzg2l_adc.c b/drivers/iio/adc/rzg2l_adc.c
index 32fbf57c362f..9d5be52bd948 100644
--- a/drivers/iio/adc/rzg2l_adc.c
+++ b/drivers/iio/adc/rzg2l_adc.c
@@ -506,10 +506,8 @@ static int rzg2l_adc_probe(struct platform_device *pdev)
}

irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(dev, "no irq resource\n");
+ if (irq < 0)
return irq;
- }

ret = devm_request_irq(dev, irq, rzg2l_adc_isr,
0, dev_name(dev), adc);
--
2.25.1

2021-11-08 15:34:37

by Geert Uytterhoeven

Subject: Re: [PATCH] iio: adc: rzg2l_adc: Remove unnecessary print function dev_err()

On Fri, Nov 5, 2021 at 3:02 AM Xu Wang <[email protected]> wrote:
> The print function dev_err() is redundant because
> platform_get_irq() already prints an error.
>
> Signed-off-by: Xu Wang <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2021-11-10 22:50:11

by Prabhakar Mahadev Lad

Subject: RE: [PATCH] iio: adc: rzg2l_adc: Remove unnecessary print function dev_err()

Hi Xu,

Thank you for the patch.

> -----Original Message-----
> From: Xu Wang <[email protected]>
> Sent: 05 November 2021 01:55
> To: Prabhakar Mahadev Lad <[email protected]>; [email protected]; [email protected]
> Cc: [email protected]; [email protected]; [email protected]
> Subject: [PATCH] iio: adc: rzg2l_adc: Remove unnecessary print function dev_err()
>
> The print function dev_err() is redundant because
> platform_get_irq() already prints an error.
>
> Signed-off-by: Xu Wang <[email protected]>
> ---
> drivers/iio/adc/rzg2l_adc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
Reviewed-by: Lad Prabhakar <[email protected]>

Cheers,
Prabhakar

> diff --git a/drivers/iio/adc/rzg2l_adc.c b/drivers/iio/adc/rzg2l_adc.c index
> 32fbf57c362f..9d5be52bd948 100644
> --- a/drivers/iio/adc/rzg2l_adc.c
> +++ b/drivers/iio/adc/rzg2l_adc.c
> @@ -506,10 +506,8 @@ static int rzg2l_adc_probe(struct platform_device *pdev)
> }
>
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> - dev_err(dev, "no irq resource\n");
> + if (irq < 0)
> return irq;
> - }
>
> ret = devm_request_irq(dev, irq, rzg2l_adc_isr,
> 0, dev_name(dev), adc);
> --
> 2.25.1

2021-11-13 16:42:35

by Jonathan Cameron

Subject: Re: [PATCH] iio: adc: rzg2l_adc: Remove unnecessary print function dev_err()

On Fri, 5 Nov 2021 01:55:04 +0000
Xu Wang <[email protected]> wrote:

> The print function dev_err() is redundant because
> platform_get_irq() already prints an error.
>
> Signed-off-by: Xu Wang <[email protected]>
Applied, thanks

Jonathan
> ---
> drivers/iio/adc/rzg2l_adc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/rzg2l_adc.c b/drivers/iio/adc/rzg2l_adc.c
> index 32fbf57c362f..9d5be52bd948 100644
> --- a/drivers/iio/adc/rzg2l_adc.c
> +++ b/drivers/iio/adc/rzg2l_adc.c
> @@ -506,10 +506,8 @@ static int rzg2l_adc_probe(struct platform_device *pdev)
> }
>
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> - dev_err(dev, "no irq resource\n");
> + if (irq < 0)
> return irq;
> - }
>
> ret = devm_request_irq(dev, irq, rzg2l_adc_isr,
> 0, dev_name(dev), adc);