Commit e21d2170f36602ae2708 ("video: remove unnecessary
platform_set_drvdata()") removed the unnecessary platform_set_drvdata(),
but left the variable "dev" unused, delete it.
v2:
Following Geert's suggestion to make change log easier reading.
Signed-off-by: Gu Zheng <[email protected]>
---
drivers/video/vga16fb.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
index 830ded4..2827333 100644
--- a/drivers/video/vga16fb.c
+++ b/drivers/video/vga16fb.c
@@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
static void vga16fb_destroy(struct fb_info *info)
{
- struct platform_device *dev = container_of(info->device, struct platform_device, dev);
iounmap(info->screen_base);
fb_dealloc_cmap(&info->cmap);
/* XXX unshare VGA regions */
--
1.7.7
On Thu, Jul 25, 2013 at 12:06 PM, Gu Zheng <[email protected]> wrote:
> Commit e21d2170f36602ae2708 ("video: remove unnecessary
> platform_set_drvdata()") removed the unnecessary platform_set_drvdata(),
> but left the variable "dev" unused, delete it.
>
> v2:
> Following Geert's suggestion to make change log easier reading.
>
> Signed-off-by: Gu Zheng <[email protected]>
> ---
Please send a v3, which has the version info under the above "---",
instead of making it a part of the patch description to be committed.
Thanks again!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Thu, 2013-07-25 at 12:11 +0200, Geert Uytterhoeven wrote:
> Please send a v3, which has the version info under the above "---",
> instead of making it a part of the patch description to be committed.
Grepping through my mail tells me this is the fourth time a patch has
been submitted to fix this trivial issue. Perhaps (one of) the
maintainers can indicate which patch, if any, the maintainers have taken
or will be taking.
Paul Bolle
On 25/07/13 13:22, Paul Bolle wrote:
> On Thu, 2013-07-25 at 12:11 +0200, Geert Uytterhoeven wrote:
>> Please send a v3, which has the version info under the above "---",
>> instead of making it a part of the patch description to be committed.
>
> Grepping through my mail tells me this is the fourth time a patch has
> been submitted to fix this trivial issue. Perhaps (one of) the
> maintainers can indicate which patch, if any, the maintainers have taken
> or will be taking.
I took the the oldest patch for this in my mailbox, from Luis.
Tomi