2017-06-14 07:48:12

by Dan Carpenter

Subject: [PATCH] thunderbolt: Fix reset response_type

There is a mistake here where we accidentally use sizeof(TB_CFG_PKG_RESET)
instead of just TB_CFG_PKG_RESET. The size of an int is 4 so it's the
same as TB_CFG_PKG_NOTIFY_ACK.

Fixes: d7f781bfdbf4 ("thunderbolt: Rework control channel to be more reliable")
Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/drivers/thunderbolt/ctl.c b/drivers/thunderbolt/ctl.c
index 69c0232a22f8..fb40dd0588b9 100644
--- a/drivers/thunderbolt/ctl.c
+++ b/drivers/thunderbolt/ctl.c
@@ -804,7 +804,7 @@ struct tb_cfg_result tb_cfg_reset(struct tb_ctl *ctl, u64 route,
req->request_type = TB_CFG_PKG_RESET;
req->response = &reply;
req->response_size = sizeof(reply);
- req->response_type = sizeof(TB_CFG_PKG_RESET);
+ req->response_type = TB_CFG_PKG_RESET;

res = tb_cfg_request_sync(ctl, req, timeout_msec);

2017-06-14 08:50:23

by Mika Westerberg

Subject: Re: [PATCH] thunderbolt: Fix reset response_type

On Wed, Jun 14, 2017 at 10:47:21AM +0300, Dan Carpenter wrote:
> There is a mistake here where we accidentally use sizeof(TB_CFG_PKG_RESET)
> instead of just TB_CFG_PKG_RESET. The size of an int is 4 so it's the
> same as TB_CFG_PKG_NOTIFY_ACK.
>
> Fixes: d7f781bfdbf4 ("thunderbolt: Rework control channel to be more reliable")
> Signed-off-by: Dan Carpenter <[email protected]>

Good catch!

Acked-by: Mika Westerberg <[email protected]>

2017-06-14 09:11:15

by Andreas Noever

Subject: Re: [PATCH] thunderbolt: Fix reset response_type

On Wed, Jun 14, 2017 at 10:42 AM, Mika Westerberg
<[email protected]> wrote:
> On Wed, Jun 14, 2017 at 10:47:21AM +0300, Dan Carpenter wrote:
>> There is a mistake here where we accidentally use sizeof(TB_CFG_PKG_RESET)
>> instead of just TB_CFG_PKG_RESET. The size of an int is 4 so it's the
>> same as TB_CFG_PKG_NOTIFY_ACK.
>>
>> Fixes: d7f781bfdbf4 ("thunderbolt: Rework control channel to be more reliable")
>> Signed-off-by: Dan Carpenter <[email protected]>
>
> Good catch!
>
> Acked-by: Mika Westerberg <[email protected]>
Signed-off-by: Andreas Noever <[email protected]>