2019-03-13 21:54:51

by Steve French

Subject: [PATCH] [CIFS] Remove unneeded statements pointed out by Coverity

cifs: remove unused value pointed out by Coverity

Detected by CoverityScan CID#1438719 ("Unused Value")

buf is reset again before being used so these two lines of code
are useless.

Signed-off-by: Steve French <[email protected]>
---
fs/cifs/connect.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index b95db2b593cb..a8e9738db691 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -1191,10 +1191,6 @@ cifs_demultiplex_thread(void *p)
continue;
}

- if (server->large_buf)
- buf = server->bigbuf;
-
-
server->lstrp = jiffies;

for (i = 0; i < num_mids; i++) {

--
Thanks,

Steve

2019-03-13 22:15:32

by ronnie sahlberg

Subject: Re: [PATCH] [CIFS] Remove unneeded statements pointed out by Coverity

reviewed by me

On Thu, Mar 14, 2019 at 7:53 AM Steve French <[email protected]> wrote:
>
> cifs: remove unused value pointed out by Coverity
>
> Detected by CoverityScan CID#1438719 ("Unused Value")
>
> buf is reset again before being used so these two lines of code
> are useless.
>
> Signed-off-by: Steve French <[email protected]>
> ---
> fs/cifs/connect.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index b95db2b593cb..a8e9738db691 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -1191,10 +1191,6 @@ cifs_demultiplex_thread(void *p)
> continue;
> }
>
> - if (server->large_buf)
> - buf = server->bigbuf;
> -
> -
> server->lstrp = jiffies;
>
> for (i = 0; i < num_mids; i++) {
>
> --
> Thanks,
>
> Steve