Hi all,
After merging the cifs tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
fs/cifs/connect.c: In function 'cifs_find_tcon':
fs/cifs/connect.c:3378:45: error: 'struct cifs_tcon' has no member named 'dfs_path'
3378 | if (!match_tcon(tcon, volume_info) || tcon->dfs_path)
| ^~
Caused by commit
f73409e5babd ("cifs: do not share tcons with DFS")
# CONFIG_CIFS_DFS_UPCALL is not set
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell
Fixed. updated cifs-2.6.git for-next with Paulo's respun version of
two patches to address the missing #ifdef
Should be ok now.
On Wed, Apr 22, 2020 at 7:31 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> fs/cifs/connect.c: In function 'cifs_find_tcon':
> fs/cifs/connect.c:3378:45: error: 'struct cifs_tcon' has no member named 'dfs_path'
> 3378 | if (!match_tcon(tcon, volume_info) || tcon->dfs_path)
> | ^~
>
> Caused by commit
>
> f73409e5babd ("cifs: do not share tcons with DFS")
>
> # CONFIG_CIFS_DFS_UPCALL is not set
>
> I have reverted that commit for today.
>
> --
> Cheers,
> Stephen Rothwell
--
Thanks,
Steve
Hello,
2021년 6월 8일 (화) 오후 7:27, Stephen Rothwell <[email protected]>님이 작성:
>
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> ld: fs/cifsd/spnego_negtokeninit.asn1.o:(.rodata.spnego_negtokeninit_decoder+0x0): multiple definition of `spnego_negtokeninit_decoder'; fs/cifs/spnego_negtoken
> init.asn1.o:(.rodata.spnego_negtokeninit_decoder+0x0): first defined here
> ld: fs/cifsd/asn1.o:(.opd+0xa8): multiple definition of `gssapi_this_mech'; fs/cifs/asn1.o:(.opd+0x18): first defined here
> ld: fs/cifsd/asn1.o: in function `.gssapi_this_mech':
> asn1.c:(.text.gssapi_this_mech+0x0): multiple definition of `.gssapi_this_mech'; fs/cifs/asn1.o:asn1.c:(.text.gssapi_this_mech+0x0): first defined here
> ld: fs/cifsd/asn1.o:(.opd+0xc0): multiple definition of `neg_token_init_mech_type'; fs/cifs/asn1.o:(.opd+0x30): first defined here
> ld: fs/cifsd/asn1.o: in function `.neg_token_init_mech_type':
> asn1.c:(.text.neg_token_init_mech_type+0x0): multiple definition of `.neg_token_init_mech_type'; fs/cifs/asn1.o:asn1.c:(.text.neg_token_init_mech_type+0x0): first defined here
>
> Caused by commit
>
> 4a957ba6daf6 ("cifs: decoding negTokenInit with generic ASN1 decoder")
I missed functions and structures generated from the ASN1 compiler
aren't static.
Steve, and Namjae,
We need to rename *.asn1 files and decoder's callback functions. Is it better
to change cifs's code?
Thanks,
Hyunchul
>
> interacting with commit
>
> fad4161b5cd0 ("cifsd: decoding gss token using lib/asn1_decoder.c")
>
> from the cifsd tree.
>
> I have reverted that cifs tree commit for today.
>
> --
> Cheers,
> Stephen Rothwell
I will back out your patch to cifs.ko
On Tue, Jun 8, 2021 at 5:53 AM Hyunchul Lee <[email protected]> wrote:
>
> Hello,
>
> 2021년 6월 8일 (화) 오후 7:27, Stephen Rothwell <[email protected]>님이 작성:
> >
> > Hi all,
> >
> > After merging the cifs tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > ld: fs/cifsd/spnego_negtokeninit.asn1.o:(.rodata.spnego_negtokeninit_decoder+0x0): multiple definition of `spnego_negtokeninit_decoder'; fs/cifs/spnego_negtoken
> > init.asn1.o:(.rodata.spnego_negtokeninit_decoder+0x0): first defined here
> > ld: fs/cifsd/asn1.o:(.opd+0xa8): multiple definition of `gssapi_this_mech'; fs/cifs/asn1.o:(.opd+0x18): first defined here
> > ld: fs/cifsd/asn1.o: in function `.gssapi_this_mech':
> > asn1.c:(.text.gssapi_this_mech+0x0): multiple definition of `.gssapi_this_mech'; fs/cifs/asn1.o:asn1.c:(.text.gssapi_this_mech+0x0): first defined here
> > ld: fs/cifsd/asn1.o:(.opd+0xc0): multiple definition of `neg_token_init_mech_type'; fs/cifs/asn1.o:(.opd+0x30): first defined here
> > ld: fs/cifsd/asn1.o: in function `.neg_token_init_mech_type':
> > asn1.c:(.text.neg_token_init_mech_type+0x0): multiple definition of `.neg_token_init_mech_type'; fs/cifs/asn1.o:asn1.c:(.text.neg_token_init_mech_type+0x0): first defined here
> >
> > Caused by commit
> >
> > 4a957ba6daf6 ("cifs: decoding negTokenInit with generic ASN1 decoder")
>
> I missed functions and structures generated from the ASN1 compiler
> aren't static.
>
> Steve, and Namjae,
> We need to rename *.asn1 files and decoder's callback functions. Is it better
> to change cifs's code?
>
> Thanks,
> Hyunchul
>
> >
> > interacting with commit
> >
> > fad4161b5cd0 ("cifsd: decoding gss token using lib/asn1_decoder.c")
> >
> > from the cifsd tree.
> >
> > I have reverted that cifs tree commit for today.
> >
> > --
> > Cheers,
> > Stephen Rothwell
--
Thanks,
Steve