2016-04-12 08:58:59

by Pengcheng Li

Subject: [PATCH] coresight: etm4x: modify q_support type

Because this operation exceed the range of boolean, so we should
modify q_support to unit32 bit.
drvdata->q_support = BMVAL(etmidr0, 15, 16)

Signed-off-by: Li Pengcheng <[email protected]>
Signed-off-by: Li Zhong <[email protected]>
---
drivers/hwtracing/coresight/coresight-etm4x.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwtracing/coresight/coresight-etm4x.h b/drivers/hwtracing/coresight/coresight-etm4x.h
index c341002..305b29a 100644
--- a/drivers/hwtracing/coresight/coresight-etm4x.h
+++ b/drivers/hwtracing/coresight/coresight-etm4x.h
@@ -330,7 +330,7 @@ struct etmv4_drvdata {
u32 ccctlr;
bool trcbb;
u32 bb_ctrl;
- bool q_support;
+ u32 q_support;
u32 vinst_ctrl;
u32 viiectlr;
u32 vissctlr;
--
1.8.3.2

2016-04-12 16:09:21

by Mathieu Poirier

Subject: Re: [PATCH] coresight: etm4x: modify q_support type

On 12 April 2016 at 02:58, lipengcheng <[email protected]> wrote:
> Because this operation exceed the range of boolean, so we should
> modify q_support to unit32 bit.
> drvdata->q_support = BMVAL(etmidr0, 15, 16)
>
> Signed-off-by: Li Pengcheng <[email protected]>
> Signed-off-by: Li Zhong <[email protected]>
> ---
> drivers/hwtracing/coresight/coresight-etm4x.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x.h b/drivers/hwtracing/coresight/coresight-etm4x.h
> index c341002..305b29a 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x.h
> +++ b/drivers/hwtracing/coresight/coresight-etm4x.h
> @@ -330,7 +330,7 @@ struct etmv4_drvdata {
> u32 ccctlr;
> bool trcbb;
> u32 bb_ctrl;
> - bool q_support;
> + u32 q_support;

Unfortunately this patch doesn't apply on my side. Please rebase on
my next tree [1], branch "next".

Thanks,
Mathieu

[1]. https://git.linaro.org/kernel/coresight.git


> u32 vinst_ctrl;
> u32 viiectlr;
> u32 vissctlr;
> --
> 1.8.3.2
>