2015-04-17 22:01:58

by Tyler Baker

Subject: [PATCH v2 6/8] selftest/x86: have no dependency on all when cross building

If the CROSS_COMPILE is set have no dependency on all.

Cc: Andy Lutomirski <[email protected]>
Signed-off-by: Tyler Baker <[email protected]>
---
tools/testing/selftests/x86/Makefile | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
index 57090ad..9962e10 100644
--- a/tools/testing/selftests/x86/Makefile
+++ b/tools/testing/selftests/x86/Makefile
@@ -9,13 +9,17 @@ CFLAGS := -O2 -g -std=gnu99 -pthread -Wall

UNAME_M := $(shell uname -m)

+ifeq ($(CROSS_COMPILE),)
# Always build 32-bit tests
all: all_32
-
# If we're on a 64-bit host, build 64-bit tests as well
ifeq ($(UNAME_M),x86_64)
all: all_32 all_64
endif
+else
+# No dependency on all when cross building
+all:
+endif

all_32: check_build32 $(BINARIES_32)

--
2.1.4

2015-04-17 22:08:29

by Andy Lutomirski

Subject: Re: [PATCH v2 6/8] selftest/x86: have no dependency on all when cross building

On Fri, Apr 17, 2015 at 3:01 PM, Tyler Baker <[email protected]> wrote:
> If the CROSS_COMPILE is set have no dependency on all.

You mean "remove all's dependency on all_32 and all_64", I think.

>
> Cc: Andy Lutomirski <[email protected]>
> Signed-off-by: Tyler Baker <[email protected]>
> ---
> tools/testing/selftests/x86/Makefile | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
> index 57090ad..9962e10 100644
> --- a/tools/testing/selftests/x86/Makefile
> +++ b/tools/testing/selftests/x86/Makefile
> @@ -9,13 +9,17 @@ CFLAGS := -O2 -g -std=gnu99 -pthread -Wall
>
> UNAME_M := $(shell uname -m)

I think you should add

all:

above. Otherwise, with CROSS_COMPILE set, the default rule won't be
'all' any more.

-Andy

>
> +ifeq ($(CROSS_COMPILE),)
> # Always build 32-bit tests
> all: all_32
> -
> # If we're on a 64-bit host, build 64-bit tests as well
> ifeq ($(UNAME_M),x86_64)
> all: all_32 all_64
> endif
> +else
> +# No dependency on all when cross building
> +all:
> +endif
>
> all_32: check_build32 $(BINARIES_32)
>
> --
> 2.1.4
>



--
Andy Lutomirski
AMA Capital Management, LLC

2015-04-17 22:15:06

by Tyler Baker

Subject: Re: [PATCH v2 6/8] selftest/x86: have no dependency on all when cross building

On 17 April 2015 at 15:08, Andy Lutomirski <[email protected]> wrote:
> On Fri, Apr 17, 2015 at 3:01 PM, Tyler Baker <[email protected]> wrote:
>> If the CROSS_COMPILE is set have no dependency on all.
>
> You mean "remove all's dependency on all_32 and all_64", I think.

Yes I'll clean this up.

>
>>
>> Cc: Andy Lutomirski <[email protected]>
>> Signed-off-by: Tyler Baker <[email protected]>
>> ---
>> tools/testing/selftests/x86/Makefile | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile
>> index 57090ad..9962e10 100644
>> --- a/tools/testing/selftests/x86/Makefile
>> +++ b/tools/testing/selftests/x86/Makefile
>> @@ -9,13 +9,17 @@ CFLAGS := -O2 -g -std=gnu99 -pthread -Wall
>>
>> UNAME_M := $(shell uname -m)
>
> I think you should add
>
> all:
>
> above. Otherwise, with CROSS_COMPILE set, the default rule won't be
> 'all' any more.

Ack. Good suggestion, thanks.

>
> -Andy
>
>>
>> +ifeq ($(CROSS_COMPILE),)
>> # Always build 32-bit tests
>> all: all_32
>> -
>> # If we're on a 64-bit host, build 64-bit tests as well
>> ifeq ($(UNAME_M),x86_64)
>> all: all_32 all_64
>> endif
>> +else
>> +# No dependency on all when cross building
>> +all:
>> +endif
>>
>> all_32: check_build32 $(BINARIES_32)
>>
>> --
>> 2.1.4
>>
>
>
>
> --
> Andy Lutomirski
> AMA Capital Management, LLC

Tyler