sir i am new in linux kernel hacking so I just want to start with
something very simple ,so for sake of simplicity and learning I fixed
only one of these warning
On Sun, Oct 02, 2016 at 09:13:32PM +0530, Nadim Almas wrote:
> sir i am new in linux kernel hacking so I just want to start with
> something very simple ,so for sake of simplicity and learning I fixed
> only one of these warning
That's great, but next time try to do a little bit more, just fixing a
single warning like that isn't all that useful overall, right?
thanks,
greg k-h
So my first patch is correct?
On Sun, Oct 2, 2016 at 9:39 PM, Greg KH <[email protected]> wrote:
> On Sun, Oct 02, 2016 at 09:13:32PM +0530, Nadim Almas wrote:
>> sir i am new in linux kernel hacking so I just want to start with
>> something very simple ,so for sake of simplicity and learning I fixed
>> only one of these warning
>
> That's great, but next time try to do a little bit more, just fixing a
> single warning like that isn't all that useful overall, right?
>
> thanks,
>
> greg k-h
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Sun, Oct 02, 2016 at 10:11:12PM +0530, Nadim Almas wrote:
> So my first patch is correct?
I don't remember, I think someone else already did the same work as you,
but as I deal with hundreds of patches a day, I can't recall. Resync on
my staging-testing branch of staging.git and rebase your patch and do
more cleanup than just one tiny one and then resend.
thanks,
greg k-h