2019-07-22 05:36:29

by Wanpeng Li

[permalink] [raw]
Subject: Re: [PATCH RESEND 1/2] KVM: LAPIC: Add pv ipi tracepoint

ping,
On Fri, 12 Jul 2019 at 15:39, Wanpeng Li <[email protected]> wrote:
>
> From: Wanpeng Li <[email protected]>
>
> Add pv ipi tracepoint.
>
> Cc: Paolo Bonzini <[email protected]>
> Cc: Radim Krčmář <[email protected]>
> Signed-off-by: Wanpeng Li <[email protected]>
> ---
> arch/x86/kvm/lapic.c | 2 ++
> arch/x86/kvm/trace.h | 25 +++++++++++++++++++++++++
> 2 files changed, 27 insertions(+)
>
> diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
> index 42da7eb..403ae3f 100644
> --- a/arch/x86/kvm/lapic.c
> +++ b/arch/x86/kvm/lapic.c
> @@ -562,6 +562,8 @@ int kvm_pv_send_ipi(struct kvm *kvm, unsigned long ipi_bitmap_low,
> irq.level = (icr & APIC_INT_ASSERT) != 0;
> irq.trig_mode = icr & APIC_INT_LEVELTRIG;
>
> + trace_kvm_pv_send_ipi(irq.vector, min, ipi_bitmap_low, ipi_bitmap_high);
> +
> if (icr & APIC_DEST_MASK)
> return -KVM_EINVAL;
> if (icr & APIC_SHORT_MASK)
> diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/trace.h
> index b5c831e..ce6ee34 100644
> --- a/arch/x86/kvm/trace.h
> +++ b/arch/x86/kvm/trace.h
> @@ -1462,6 +1462,31 @@ TRACE_EVENT(kvm_hv_send_ipi_ex,
> __entry->vector, __entry->format,
> __entry->valid_bank_mask)
> );
> +
> +/*
> + * Tracepoints for kvm_pv_send_ipi.
> + */
> +TRACE_EVENT(kvm_pv_send_ipi,
> + TP_PROTO(u32 vector, u32 min, unsigned long ipi_bitmap_low, unsigned long ipi_bitmap_high),
> + TP_ARGS(vector, min, ipi_bitmap_low, ipi_bitmap_high),
> +
> + TP_STRUCT__entry(
> + __field(u32, vector)
> + __field(u32, min)
> + __field(unsigned long, ipi_bitmap_low)
> + __field(unsigned long, ipi_bitmap_high)
> + ),
> +
> + TP_fast_assign(
> + __entry->vector = vector;
> + __entry->min = min;
> + __entry->ipi_bitmap_low = ipi_bitmap_low;
> + __entry->ipi_bitmap_high = ipi_bitmap_high;
> + ),
> +
> + TP_printk("vector %d min 0x%x ipi_bitmap_low 0x%lx ipi_bitmap_high 0x%lx",
> + __entry->vector, __entry->min, __entry->ipi_bitmap_low, __entry->ipi_bitmap_high)
> +);
> #endif /* _TRACE_KVM_H */
>
> #undef TRACE_INCLUDE_PATH
> --
> 2.7.4
>