2017-11-09 11:09:47

by Wanpeng Li

[permalink] [raw]
Subject: Re: [PATCH RESEND 2/3] KVM: Add paravirt remote TLB flush

2017-11-09 19:02 GMT+08:00 Paolo Bonzini <[email protected]>:
> On 09/11/2017 12:01, Wanpeng Li wrote:
>> 2017-11-09 18:48 GMT+08:00 Paolo Bonzini <[email protected]>:
>>> On 09/11/2017 03:02, Wanpeng Li wrote:
>>>> @@ -484,6 +511,8 @@ void __init kvm_guest_init(void)
>>>> pv_time_ops.steal_clock = kvm_steal_clock;
>>>> }
>>>>
>>>> + pv_mmu_ops.flush_tlb_others = kvm_flush_tlb_others;
>>>
>>> This needs to be keyed on a new CPUID feature bit. Eduardo is also
>>
>> Will do.
>>
>>> adding a new "PV_DEDICATED" hint and you might disable PV TLB flush when
>>> PV_DEDICATED is set.
>>
>> Why disable PV TLB flush for PV_DEDICATED(qspinlock)?
>
> PV_DEDICATED says pretty much that it is very unlikely to have a
> preempted vCPU. Therefore, the cpumask loop is unnecessary.

Thanks for pointing out this. :)

Regards,
Wanpeng Li

From 1583586262404822977@xxx Thu Nov 09 11:05:46 +0000 2017
X-GM-THRID: 1583551558691477552
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread