2020-05-28 09:21:23

by Markus Elfring

Subject: Re: [PATCH] rtc: rv3028: Add missed check for devm_regmap_init_i2c()

> rv3028_probe() misses a check for devm_regmap_init_i2c().

Such information is helpful.


> Add the missed check

Thanks for another completion of the exception handling.


> to fix it.

I suggest to replace this wording by the tag “Fixes” for the commit message.
How do you think about to take this possibility into account
for any more patches?

Regards,
Markus

2020-05-28 10:26:14

by Chuhong Yuan

Subject: Re: [PATCH] rtc: rv3028: Add missed check for devm_regmap_init_i2c()

On Thu, May 28, 2020 at 5:17 PM Markus Elfring <[email protected]> wrote:
>
> > rv3028_probe() misses a check for devm_regmap_init_i2c().
>
> Such information is helpful.
>
>
> > Add the missed check
>
> Thanks for another completion of the exception handling.
>
>
> > to fix it.
>
> I suggest to replace this wording by the tag “Fixes” for the commit message.
> How do you think about to take this possibility into account
> for any more patches?
>

I got it. I have added fixes tags in my newly sent patches.

Regards,
Chuhong

> Regards,
> Markus