go7007_snd_init() misses a snd_card_free() in an error path.
Add the missed call to fix it.
Signed-off-by: Chuhong Yuan <[email protected]>
---
drivers/media/usb/go7007/snd-go7007.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/usb/go7007/snd-go7007.c b/drivers/media/usb/go7007/snd-go7007.c
index b05fa227ffb2..dced8c019514 100644
--- a/drivers/media/usb/go7007/snd-go7007.c
+++ b/drivers/media/usb/go7007/snd-go7007.c
@@ -243,6 +243,7 @@ int go7007_snd_init(struct go7007 *go)
ret = snd_device_new(gosnd->card, SNDRV_DEV_LOWLEVEL, go,
&go7007_snd_device_ops);
if (ret < 0) {
+ snd_card_free(gosnd->card);
kfree(gosnd);
return ret;
}
--
2.24.0
> go7007_snd_init() misses a snd_card_free() in an error path.
> Add the missed call to fix it.
How do you think about to take another look also at the previous update suggestion
“[PATCH 5/6] [media] go7007: Use common error handling code in go7007_snd_init()”?
https://lore.kernel.org/linux-media/[email protected]/
https://lore.kernel.org/patchwork/patch/831887/
https://lkml.org/lkml/2017/9/19/115
Regards,
Markus
On Fri, Dec 6, 2019 at 10:11 PM Markus Elfring <[email protected]> wrote:
>
> > go7007_snd_init() misses a snd_card_free() in an error path.
> > Add the missed call to fix it.
>
> How do you think about to take another look also at the previous update suggestion
> “[PATCH 5/6] [media] go7007: Use common error handling code in go7007_snd_init()”?
> https://lore.kernel.org/linux-media/[email protected]/
> https://lore.kernel.org/patchwork/patch/831887/
> https://lkml.org/lkml/2017/9/19/115
>
I think using goto is really much better than freeing after every error.
I will send a new version if others also agree with this pattern.
Regards,
Chuhong
> Regards,
> Markus
> I think using goto is really much better than freeing after every error.
Thanks for your positive feedback.
> I will send a new version if others also agree with this pattern.
* The error handling pattern would be supported by the Linux coding style.
The agreement on corresponding changes can occasionally become more challenging.
* I would interpret Dan Carpenter's review comment (from 2017-09-19) in the way
that he should be mentioned by the tag “Reported-by” in a subsequent patch.
https://lkml.org/lkml/2017/9/19/115
Regards,
Markus