LinuxLists.cc - [PATCH] infiniband: bnxt_re: qplib: Check the return value of send

2018-12-26 19:06:10

Subject: [PATCH] infiniband: bnxt_re: qplib: Check the return value of send_message

In bnxt_qplib_map_tc2cos(), bnxt_qplib_rcfw_send_message() can return
an error value. The fix returns the error from the latter function
upstream.

Signed-off-by: Aditya Pakki <[email protected]>
---
drivers/infiniband/hw/bnxt_re/qplib_sp.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/infiniband/hw/bnxt_re/qplib_sp.c b/drivers/infiniband/hw/bnxt_re/qplib_sp.c
index 5216b5f844cc..adb8eae5193c 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_sp.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_sp.c
@@ -778,9 +778,8 @@ int bnxt_qplib_map_tc2cos(struct bnxt_qplib_res *res, u16 *cids)
req.cos0 = cpu_to_le16(cids[0]);
req.cos1 = cpu_to_le16(cids[1]);

- bnxt_qplib_rcfw_send_message(rcfw, (void *)&req, (void *)&resp, NULL,
- 0);
- return 0;
+ return bnxt_qplib_rcfw_send_message(rcfw, (void *)&req, (void *)&resp,
+ NULL, 0);
}

int bnxt_qplib_get_roce_stats(struct bnxt_qplib_rcfw *rcfw,
--
2.17.1

2018-12-31 06:11:12

by Devesh Sharma

[permalink] [raw]

Subject: Re: [PATCH] infiniband: bnxt_re: qplib: Check the return value of send_message

On Thu, Dec 27, 2018 at 12:26 AM Aditya Pakki <[email protected]> wrote:
>
> In bnxt_qplib_map_tc2cos(), bnxt_qplib_rcfw_send_message() can return
> an error value. The fix returns the error from the latter function
> upstream.
>
> Signed-off-by: Aditya Pakki <[email protected]>
> ---
> drivers/infiniband/hw/bnxt_re/qplib_sp.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/hw/bnxt_re/qplib_sp.c b/drivers/infiniband/hw/bnxt_re/qplib_sp.c
> index 5216b5f844cc..adb8eae5193c 100644
> --- a/drivers/infiniband/hw/bnxt_re/qplib_sp.c
> +++ b/drivers/infiniband/hw/bnxt_re/qplib_sp.c
> @@ -778,9 +778,8 @@ int bnxt_qplib_map_tc2cos(struct bnxt_qplib_res *res, u16 *cids)
> req.cos0 = cpu_to_le16(cids[0]);
> req.cos1 = cpu_to_le16(cids[1]);
>
> - bnxt_qplib_rcfw_send_message(rcfw, (void *)&req, (void *)&resp, NULL,
> - 0);
> - return 0;
> + return bnxt_qplib_rcfw_send_message(rcfw, (void *)&req, (void *)&resp,
> + NULL, 0);
> }
>
> int bnxt_qplib_get_roce_stats(struct bnxt_qplib_rcfw *rcfw,
> --
> 2.17.1
>

Acked-By: Devesh Sharma <[email protected]>

2019-01-01 10:23:15

by Leon Romanovsky

[permalink] [raw]

Subject: Re: [PATCH] infiniband: bnxt_re: qplib: Check the return value of send_message

On Wed, Dec 26, 2018 at 12:56:22PM -0600, Aditya Pakki wrote:
> In bnxt_qplib_map_tc2cos(), bnxt_qplib_rcfw_send_message() can return
> an error value. The fix returns the error from the latter function
> upstream.
>
> Signed-off-by: Aditya Pakki <[email protected]>
> ---
> drivers/infiniband/hw/bnxt_re/qplib_sp.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/hw/bnxt_re/qplib_sp.c b/drivers/infiniband/hw/bnxt_re/qplib_sp.c
> index 5216b5f844cc..adb8eae5193c 100644
> --- a/drivers/infiniband/hw/bnxt_re/qplib_sp.c
> +++ b/drivers/infiniband/hw/bnxt_re/qplib_sp.c
> @@ -778,9 +778,8 @@ int bnxt_qplib_map_tc2cos(struct bnxt_qplib_res *res, u16 *cids)
> req.cos0 = cpu_to_le16(cids[0]);
> req.cos1 = cpu_to_le16(cids[1]);
>
> - bnxt_qplib_rcfw_send_message(rcfw, (void *)&req, (void *)&resp, NULL,
> - 0);
> - return 0;
> + return bnxt_qplib_rcfw_send_message(rcfw, (void *)&req, (void *)&resp,
> + NULL, 0);
> }

AFAIK, there is no need to do casting to/from void*.

Thanks

>
> int bnxt_qplib_get_roce_stats(struct bnxt_qplib_rcfw *rcfw,
> --
> 2.17.1
>

Attachments:

(No filename) (1.13 kB)
signature.asc (817.00 B)
Download all attachments

2019-01-03 03:54:53

by Jason Gunthorpe

[permalink] [raw]