2023-01-04 02:14:43

by andrey.konovalov

Subject: [PATCH] kasan: mark kasan_kunit_executing as static

From: Andrey Konovalov <[email protected]>

Mark kasan_kunit_executing as static, as it is only used within
mm/kasan/report.c.

Fixes: c8c7016f50c8 ("kasan: fail non-kasan KUnit tests on KASAN reports")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Andrey Konovalov <[email protected]>
---
mm/kasan/report.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/kasan/report.c b/mm/kasan/report.c
index 1d02757e90a3..22598b20c7b7 100644
--- a/mm/kasan/report.c
+++ b/mm/kasan/report.c
@@ -119,7 +119,7 @@ EXPORT_SYMBOL_GPL(kasan_restore_multi_shot);
* Whether the KASAN KUnit test suite is currently being executed.
* Updated in kasan_test.c.
*/
-bool kasan_kunit_executing;
+static bool kasan_kunit_executing;

void kasan_kunit_test_suite_start(void)
{
--
2.25.1

2023-01-04 09:18:40

by Marco Elver

Subject: Re: [PATCH] kasan: mark kasan_kunit_executing as static

On Wed, 4 Jan 2023 at 02:09, <[email protected]> wrote:
>
> From: Andrey Konovalov <[email protected]>
>
> Mark kasan_kunit_executing as static, as it is only used within
> mm/kasan/report.c.
>
> Fixes: c8c7016f50c8 ("kasan: fail non-kasan KUnit tests on KASAN reports")
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Andrey Konovalov <[email protected]>

Reviewed-by: Marco Elver <[email protected]>

> ---
> mm/kasan/report.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/kasan/report.c b/mm/kasan/report.c
> index 1d02757e90a3..22598b20c7b7 100644
> --- a/mm/kasan/report.c
> +++ b/mm/kasan/report.c
> @@ -119,7 +119,7 @@ EXPORT_SYMBOL_GPL(kasan_restore_multi_shot);
> * Whether the KASAN KUnit test suite is currently being executed.
> * Updated in kasan_test.c.
> */
> -bool kasan_kunit_executing;
> +static bool kasan_kunit_executing;
>
> void kasan_kunit_test_suite_start(void)
> {
> --
> 2.25.1
>